chrome/browser/sessions/session_backend.cc - Issue 694813003: Changing SessionService to have a BaseSessionService, not being one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/session_backend.cc

Issue 694813003: Changing SessionService to have a BaseSessionService, not being one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and addressed Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sessions/persistent_tab_restore_service.cc ('K') | « chrome/browser/sessions/session_backend.h ('k') | chrome/browser/sessions/session_service.h » ('j') | chrome/browser/ui/browser_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/session_backend.cc

diff --git a/chrome/browser/sessions/session_backend.cc b/chrome/browser/sessions/session_backend.cc

index dc0b66e5306ea4b098e85444a9e30db09a5a7c49..cd313033d6edcf8985655ee0cee37060edc594d9 100644

--- a/chrome/browser/sessions/session_backend.cc

+++ b/chrome/browser/sessions/session_backend.cc

@@ -240,7 +240,7 @@ void SessionBackend::AppendCommands(

void SessionBackend::ReadLastSessionCommands(

const base::CancelableTaskTracker::IsCanceledCallback& is_canceled,

- const BaseSessionService::InternalGetCommandsCallback& callback) {

+ const BaseSessionService::GetCommandsCallback& callback) {

if (is_canceled.Run())

return;