chrome/browser/sessions/base_session_service_delegate_impl.cc - Issue 694813003: Changing SessionService to have a BaseSessionService, not being one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sessions/base_session_service_delegate_impl.cc

Issue 694813003: Changing SessionService to have a BaseSessionService, not being one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased and addressed Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sessions/base_session_service.h ('K') | « chrome/browser/sessions/base_session_service_delegate_impl.h ('k') | chrome/browser/sessions/persistent_tab_restore_service.cc » ('j') | chrome/browser/sessions/persistent_tab_restore_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sessions/base_session_service_delegate_impl.cc

diff --git a/chrome/browser/sessions/base_session_service_delegate_impl.cc b/chrome/browser/sessions/base_session_service_delegate_impl.cc

index 972da4d6ee7ef9c92f64bdb9984b53c0472e5d2a..cd584bf87ae77f64a89e5f72ab282787229a63cb 100644

--- a/chrome/browser/sessions/base_session_service_delegate_impl.cc

+++ b/chrome/browser/sessions/base_session_service_delegate_impl.cc

@@ -20,7 +20,8 @@ base::SequencedWorkerPool* BaseSessionServiceDelegateImpl::GetBlockingPool() {

bool BaseSessionServiceDelegateImpl::ShouldTrackEntry(const GURL& url) {

// Blacklist chrome://quit and chrome://restart to avoid quit or restart

// loops.

- return !(url.SchemeIs(content::kChromeUIScheme) &&

+ return url.is_valid() &&

+ !(url.SchemeIs(content::kChromeUIScheme) &&

(url.host() == chrome::kChromeUIQuitHost ||

url.host() == chrome::kChromeUIRestartHost));

}