Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 694813003: Changing SessionService to have a BaseSessionService, not being one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed browser tests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/session_service_utils.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/browser_browsertest.cc
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc
index e497ce415c830db0653d67e97510bf2b64a4b82a..ac490162e8a7b0c5dccf7005ff7763aa55fc9f9e 100644
--- a/chrome/browser/ui/browser_browsertest.cc
+++ b/chrome/browser/ui/browser_browsertest.cc
@@ -2206,6 +2206,11 @@ class NoStartupWindowTest : public BrowserTest {
command_line->AppendSwitch(switches::kNoStartupWindow);
command_line->AppendSwitch(switches::kKeepAliveForTest);
}
+
+ // Returns true if any commands were processed.
+ bool ProcessedAnyCommands(BaseSessionService* base_session_service) {
+ return base_session_service->ProcessedAnyCommandsForTest();
+ }
};
IN_PROC_BROWSER_TEST_F(NoStartupWindowTest, NoStartupWindowBasicTest) {
@@ -2240,13 +2245,15 @@ IN_PROC_BROWSER_TEST_F(NoStartupWindowTest, DontInitSessionServiceForApps) {
SessionService* session_service =
SessionServiceFactory::GetForProfile(profile);
- ASSERT_FALSE(session_service->processed_any_commands());
+ BaseSessionService* base_session_service =
+ session_service->GetBaseSessionServiceForTest();
+ ASSERT_FALSE(ProcessedAnyCommands(base_session_service));
ui_test_utils::BrowserAddedObserver browser_added_observer;
CreateBrowserForApp("blah", profile);
browser_added_observer.WaitForSingleNewBrowser();
- ASSERT_FALSE(session_service->processed_any_commands());
+ ASSERT_FALSE(ProcessedAnyCommands(base_session_service));
}
#endif // !defined(OS_CHROMEOS)
« no previous file with comments | « chrome/browser/sessions/session_service_utils.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698