Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2734)

Unified Diff: chrome/browser/sessions/session_service_commands.h

Issue 694813003: Changing SessionService to have a BaseSessionService, not being one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed browser tests Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sessions/session_service.cc ('k') | chrome/browser/sessions/session_service_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/session_service_commands.h
diff --git a/chrome/browser/sessions/session_service_commands.h b/chrome/browser/sessions/session_service_commands.h
index 25d92413bcd4eb046c084da82bbdee0bb5e4b73e..cccf11cf70d5d000a90a33f918ad9692765dbf0b 100644
--- a/chrome/browser/sessions/session_service_commands.h
+++ b/chrome/browser/sessions/session_service_commands.h
@@ -68,12 +68,12 @@ scoped_ptr<SessionCommand> CreateSetWindowAppNameCommand(
const SessionID& window_id,
const std::string& app_name);
-// Searches for a pending command in |pending_commands| that can be replaced
-// with |command|. If one is found, pending command is removed, the command
-// is added to the pending commands (taken ownership) and true is returned.
-bool ReplacePendingCommand(
- ScopedVector<SessionCommand>& pending_commands,
- scoped_ptr<SessionCommand>* command);
+// Searches for a pending command using |base_session_service| that can be
+// replaced with |command|. If one is found, pending command is removed, the
+// command is added to the pending commands (taken ownership) and true is
+// returned.
+bool ReplacePendingCommand(BaseSessionService* base_session_service,
+ scoped_ptr<SessionCommand>* command);
// Returns true if provided |command| either closes a window or a tab.
bool IsClosingCommand(SessionCommand* command);
« no previous file with comments | « chrome/browser/sessions/session_service.cc ('k') | chrome/browser/sessions/session_service_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698