Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: chrome/browser/extensions/extension_service.cc

Issue 6948007: Merge 84502 - avoid dereferencing NULL extension in ExtensionHost (Closed) Base URL: svn://svn.chromium.org/chrome/branches/742/src/
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/extensions/extension_process_manager.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_service.h" 5 #include "chrome/browser/extensions/extension_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <set> 8 #include <set>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 1928 matching lines...) Expand 10 before | Expand all | Expand 10 after
1939 std::string path_str = UTF16ToUTF8(extension_path.LossyDisplayName()); 1939 std::string path_str = UTF16ToUTF8(extension_path.LossyDisplayName());
1940 std::string message = base::StringPrintf( 1940 std::string message = base::StringPrintf(
1941 "Could not load extension from '%s'. %s", 1941 "Could not load extension from '%s'. %s",
1942 path_str.c_str(), error.c_str()); 1942 path_str.c_str(), error.c_str());
1943 ExtensionErrorReporter::GetInstance()->ReportError(message, be_noisy); 1943 ExtensionErrorReporter::GetInstance()->ReportError(message, be_noisy);
1944 } 1944 }
1945 1945
1946 void ExtensionService::DidCreateRenderViewForBackgroundPage( 1946 void ExtensionService::DidCreateRenderViewForBackgroundPage(
1947 ExtensionHost* host) { 1947 ExtensionHost* host) {
1948 OrphanedDevTools::iterator iter = 1948 OrphanedDevTools::iterator iter =
1949 orphaned_dev_tools_.find(host->extension()->id()); 1949 orphaned_dev_tools_.find(host->extension_id());
1950 if (iter == orphaned_dev_tools_.end()) 1950 if (iter == orphaned_dev_tools_.end())
1951 return; 1951 return;
1952 1952
1953 DevToolsManager::GetInstance()->AttachClientHost( 1953 DevToolsManager::GetInstance()->AttachClientHost(
1954 iter->second, host->render_view_host()); 1954 iter->second, host->render_view_host());
1955 orphaned_dev_tools_.erase(iter); 1955 orphaned_dev_tools_.erase(iter);
1956 } 1956 }
1957 1957
1958 void ExtensionService::Observe(NotificationType type, 1958 void ExtensionService::Observe(NotificationType type,
1959 const NotificationSource& source, 1959 const NotificationSource& source,
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
2079 2079
2080 ExtensionService::NaClModuleInfoList::iterator 2080 ExtensionService::NaClModuleInfoList::iterator
2081 ExtensionService::FindNaClModule(const GURL& url) { 2081 ExtensionService::FindNaClModule(const GURL& url) {
2082 for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin(); 2082 for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin();
2083 iter != nacl_module_list_.end(); ++iter) { 2083 iter != nacl_module_list_.end(); ++iter) {
2084 if (iter->url == url) 2084 if (iter->url == url)
2085 return iter; 2085 return iter;
2086 } 2086 }
2087 return nacl_module_list_.end(); 2087 return nacl_module_list_.end();
2088 } 2088 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/extension_process_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698