extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc - Issue 694773003: Allow URL requests for object/embed tags to be intercepted as streams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc

Issue 694773003: Allow URL requests for object/embed tags to be intercepted as streams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-guest-view-container-3

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc ('k') | extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc b/extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc

index 12d14bd1da1ae639b6242763a2e2d5aa2e6da6ca..06e5c5b8c32a4a639d6202b95b1ece7e744a5037 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc

+++ b/extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc

@@ -95,6 +95,7 @@ TEST(WebRequestConditionTest, CreateCondition) {

-1, // render_frame_id

true, // is_main_frame

false, // parent_is_main_frame

+ true, // allow_download

false); // is_async

EXPECT_TRUE(result->IsFulfilled(request_data));

@@ -114,6 +115,7 @@ TEST(WebRequestConditionTest, CreateCondition) {

-1, // render_frame_id

false, // is_main_frame

false, // parent_is_main_frame

+ true, // allow_download

false); // is_async

EXPECT_FALSE(result->IsFulfilled(request_data));

}

@@ -162,6 +164,7 @@ TEST(WebRequestConditionTest, CreateConditionFirstPartyForCookies) {

-1, // render_frame_id

true, // is_main_frame

false, // parent_is_main_frame

+ true, // allow_download

false); // is_async

EXPECT_TRUE(result->IsFulfilled(request_data));

}