Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: content/browser/loader/buffered_resource_handler_unittest.cc

Issue 694773003: Allow URL requests for object/embed tags to be intercepted as streams. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor-guest-view-container-3
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "content/browser/loader/buffered_resource_handler.h"
6
7 #include "base/logging.h"
8 #include "base/macros.h"
9 #include "base/memory/scoped_ptr.h"
10 #include "content/browser/loader/resource_dispatcher_host_impl.h"
11 #include "content/public/browser/resource_controller.h"
12 #include "content/public/browser/resource_dispatcher_host_delegate.h"
13 #include "content/public/browser/resource_request_info.h"
14 #include "content/public/common/resource_response.h"
15 #include "content/public/test/test_browser_thread_bundle.h"
16 #include "content/public/test/test_utils.h"
17 #include "net/url_request/url_request_context.h"
18 #include "testing/gtest/include/gtest/gtest.h"
19 #include "url/gurl.h"
20
21 namespace content {
22
23 namespace {
24
25 class TestResourceHandler : public ResourceHandler {
26 public:
27 TestResourceHandler() : ResourceHandler(nullptr) {}
28
29 void SetController(ResourceController* controller) override {}
30
31 bool OnUploadProgress(uint64 position, uint64 size) override {
32 NOTREACHED();
33 return false;
34 }
35
36 bool OnRequestRedirected(const net::RedirectInfo& redirect_info,
37 ResourceResponse* response,
38 bool* defer) override {
39 NOTREACHED();
40 return false;
41 }
42
43 bool OnResponseStarted(ResourceResponse* response, bool* defer) override {
44 return false;
45 }
46
47 bool OnWillStart(const GURL& url, bool* defer) override {
48 NOTREACHED();
49 return false;
50 }
51
52 bool OnBeforeNetworkStart(const GURL& url, bool* defer) override {
53 NOTREACHED();
54 return false;
55 }
56
57 bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
58 int* buf_size,
59 int min_size) override {
60 NOTREACHED();
61 return false;
62 }
63
64 bool OnReadCompleted(int bytes_read, bool* defer) override {
65 NOTREACHED();
66 return false;
67 }
68
69 void OnResponseCompleted(const net::URLRequestStatus& status,
70 const std::string& security_info,
71 bool* defer) override {
72 }
73
74 void OnDataDownloaded(int bytes_downloaded) override {
75 NOTREACHED();
76 }
77
78 private:
79 DISALLOW_COPY_AND_ASSIGN(TestResourceHandler);
80 };
81
82 class TestResourceDispatcherHost : public ResourceDispatcherHostImpl {
83 public:
84 explicit TestResourceDispatcherHost(bool stream_has_handler)
85 : stream_has_handler_(stream_has_handler),
86 intercepted_as_stream_(false) {}
87
88 bool intercepted_as_stream() const { return intercepted_as_stream_; }
89
90 scoped_ptr<ResourceHandler> CreateResourceHandlerForDownload(
91 net::URLRequest* request,
92 bool is_content_initiated,
93 bool must_download,
94 uint32 id,
95 scoped_ptr<DownloadSaveInfo> save_info,
96 const DownloadUrlParameters::OnStartedCallback& started_cb) override {
97 return scoped_ptr<ResourceHandler>(new TestResourceHandler).Pass();
98 }
99
100 scoped_ptr<ResourceHandler> MaybeInterceptAsStream(
101 net::URLRequest* request,
102 ResourceResponse* response,
103 std::string* payload) override {
104 if (stream_has_handler_) {
105 intercepted_as_stream_ = true;
106 return scoped_ptr<ResourceHandler>(new TestResourceHandler).Pass();
107 } else {
108 return scoped_ptr<ResourceHandler>();
109 }
110 }
111
112 private:
113 // Whether the URL request should be intercepted as a stream.
114 bool stream_has_handler_;
115
116 // Whether the URL request has been intercepted as a stream.
117 bool intercepted_as_stream_;
118 };
119
120 class TestResourceDispatcherHostDelegate
121 : public ResourceDispatcherHostDelegate {
122 public:
123 TestResourceDispatcherHostDelegate(bool must_download)
124 : must_download_(must_download) {
125 }
126
127 bool ShouldForceDownloadResource(const GURL& url,
128 const std::string& mime_type) override {
129 return must_download_;
130 }
131
132 private:
133 const bool must_download_;
134 };
135
136 class TestResourceController : public ResourceController {
137 public:
138 void Cancel() override {}
139
140 void CancelAndIgnore() override {
141 NOTREACHED();
142 }
143
144 void CancelWithError(int error_code) override {
145 NOTREACHED();
146 }
147
148 void Resume() override {
149 NOTREACHED();
150 }
151 };
152
153 class BufferedResourceHandlerTest : public testing::Test {
154 public:
155 BufferedResourceHandlerTest() : stream_has_handler_(false) {}
156
157 void set_stream_has_handler(bool stream_has_handler) {
158 stream_has_handler_ = stream_has_handler;
159 }
160
161 bool TestStreamIsIntercepted(bool allow_download,
162 bool must_download,
163 ResourceType request_resource_type);
164
165 private:
166 // Whether the URL request should be intercepted as a stream.
167 bool stream_has_handler_;
168
169 TestBrowserThreadBundle thread_bundle_;
170 };
171
172 bool BufferedResourceHandlerTest::TestStreamIsIntercepted(
173 bool allow_download,
174 bool must_download,
175 ResourceType request_resource_type) {
176 net::URLRequestContext context;
177 scoped_ptr<net::URLRequest> request(context.CreateRequest(
178 GURL("http://www.google.com"), net::DEFAULT_PRIORITY, nullptr, nullptr));
179 bool is_main_frame = request_resource_type == RESOURCE_TYPE_MAIN_FRAME;
180 ResourceRequestInfo::AllocateForTesting(
181 request.get(),
182 request_resource_type,
183 nullptr, // context
184 0, // render_process_id
185 0, // render_view_id
186 0, // render_frame_id
187 is_main_frame, // is_main_frame
188 false, // parent_is_main_frame
189 allow_download, // allow_download
190 true); // is_async
191
192 TestResourceDispatcherHost host(stream_has_handler_);
193 TestResourceDispatcherHostDelegate host_delegate(must_download);
194 host.SetDelegate(&host_delegate);
195
196 scoped_ptr<ResourceHandler> buffered_handler(
197 new BufferedResourceHandler(
198 scoped_ptr<ResourceHandler>(new TestResourceHandler()).Pass(),
199 &host, request.get()));
200 TestResourceController resource_controller;
201 buffered_handler->SetController(&resource_controller);
202
203 scoped_refptr<ResourceResponse> response(new ResourceResponse);
204 // The MIME type isn't important but it shouldn't be empty.
205 response->head.mime_type = "application/pdf";
206
207 bool defer = false;
208 buffered_handler->OnResponseStarted(response.get(), &defer);
209
210 content::RunAllPendingInMessageLoop();
211
212 return host.intercepted_as_stream();
213 }
214
215 // TODO(raymes): Currently fails on Mac due to dependency on plugin
216 // initialization.
217 #if defined(OS_MACOSX)
218 #define MAYBE_StreamHandling DISABLED_StreamHandling
219 #else
220 #define MAYBE_StreamHandling StreamHandling
221 #endif
222 // Test that stream requests are correctly intercepted under the right
223 // circumstances.
224 TEST_F(BufferedResourceHandlerTest, MAYBE_StreamHandling) {
225 bool allow_download;
226 bool must_download;
227 ResourceType resource_type;
228
229 // Ensure the stream is handled by MaybeInterceptAsStream in the
230 // ResourceDispatcherHost.
231 set_stream_has_handler(true);
232
233 // Main frame request with no download allowed. Stream shouldn't be
234 // intercepted.
235 allow_download = false;
236 must_download = false;
237 resource_type = RESOURCE_TYPE_MAIN_FRAME;
238 EXPECT_FALSE(
239 TestStreamIsIntercepted(allow_download, must_download, resource_type));
240
241 // Main frame request with download allowed. Stream should be intercepted.
242 allow_download = true;
243 must_download = false;
244 resource_type = RESOURCE_TYPE_MAIN_FRAME;
245 EXPECT_TRUE(
246 TestStreamIsIntercepted(allow_download, must_download, resource_type));
247
248 // Main frame request with download forced. Stream shouldn't be intercepted.
249 allow_download = true;
250 must_download = true;
251 resource_type = RESOURCE_TYPE_MAIN_FRAME;
252 EXPECT_FALSE(
253 TestStreamIsIntercepted(allow_download, must_download, resource_type));
254
255 // Sub-resource request with download not allowed. Stream shouldn't be
256 // intercepted.
257 allow_download = false;
258 must_download = false;
259 resource_type = RESOURCE_TYPE_SUB_RESOURCE;
260 EXPECT_FALSE(
261 TestStreamIsIntercepted(allow_download, must_download, resource_type));
262
263 // Object request with download not allowed. Stream should be intercepted.
264 allow_download = false;
265 must_download = false;
266 resource_type = RESOURCE_TYPE_OBJECT;
267 EXPECT_TRUE(
268 TestStreamIsIntercepted(allow_download, must_download, resource_type));
269
270 // Test the cases where the stream isn't handled by MaybeInterceptAsStream
271 // in the ResourceDispatcherHost.
272 set_stream_has_handler(false);
273
274 allow_download = false;
275 must_download = false;
276 resource_type = RESOURCE_TYPE_OBJECT;
277 EXPECT_FALSE(
278 TestStreamIsIntercepted(allow_download, must_download, resource_type));
279
280 allow_download = true;
281 must_download = false;
282 resource_type = RESOURCE_TYPE_MAIN_FRAME;
283 EXPECT_FALSE(
284 TestStreamIsIntercepted(allow_download, must_download, resource_type));
285 }
286
287 } // namespace
288
289 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/loader/buffered_resource_handler.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698