Allow URL requests for object/embed tags to be intercepted as streams.

content/browser/loader/buffered_resource_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/loader/buffered_resource_handler.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 294 matching lines @@
   const std::string& mime_type = response_->head.mime_type;
 
   if (net::IsSupportedCertificateMimeType(mime_type)) {
     // Install certificate file.
     info->set_is_download(true);
     scoped_ptr<ResourceHandler> handler(
         new CertificateResourceHandler(request()));
     return UseAlternateNextHandler(handler.Pass(), std::string());
   }
 
+  // info->allow_download() == true implies
+  // info->GetResourceType() == RESOURCE_TYPE_MAIN_FRAME or
+  // info->GetResourceType() == RESOURCE_TYPE_SUB_FRAME.
+  if (info->allow_download()) {
+    DCHECK(info->GetResourceType() == RESOURCE_TYPE_MAIN_FRAME ||
+           info->GetResourceType() == RESOURCE_TYPE_SUB_FRAME);

[mmenke, 2014/11/18 16:32:17]

Can move this down below the "!info->allow_download()" check before, I think.

[raymes, 2014/11/19 04:08:37]

Done.

+  }
+
+  // Allow requests for object/embed tags to be intercepted as streams.
+  if (info->GetResourceType() == content::RESOURCE_TYPE_OBJECT) {
+    DCHECK(!info->allow_download());
+    DCHECK(!net::IsSupportedMimeType(mime_type));

[mmenke, 2014/11/18 16:32:17]

In addition to never getting intercepted as streams, they're also never of
RESOURCE_TYPE_OBJECT?

[raymes, 2014/11/19 04:08:37]

Arg no that's not necessarily true. I had already moved the DCHECK into the if
statement below but forgot to upload the patchset. Thanks for catching.

+    std::string payload;
+    scoped_ptr<ResourceHandler> handler(
+        host_->MaybeInterceptAsStream(request(), response_.get(), &payload));
+    if (handler) {
+      return UseAlternateNextHandler(handler.Pass(), payload);
+    }
+  }
+
   if (!info->allow_download())
     return true;
 
   bool must_download = MustDownload();
   if (!must_download) {
     if (net::IsSupportedMimeType(mime_type))
       return true;
 
     std::string payload;
     scoped_ptr<ResourceHandler> handler(
@@ skipping 169 matching lines @@
   request()->LogUnblocked();
   bool defer = false;
   if (!ProcessResponse(&defer)) {
     controller()->Cancel();
   } else if (!defer) {
     controller()->Resume();
   }
 }
 
 }  // namespace content