Skip the CallFunctionStub when the callee function can be statically determined.

Skip the CallFunctionStub when the callee function can be statically determined.

R=mstarzinger@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=25042

[Michael Starzinger, 2014-10-31 12:28:06]

Looking good, just one suggestion.

https://codereview.chromium.org/694773002/diff/1/src/compiler/js-generic-lowe...
File src/compiler/js-generic-lowering.cc (right):

https://codereview.chromium.org/694773002/diff/1/src/compiler/js-generic-lowe...
src/compiler/js-generic-lowering.cc:427: if (func.HasValue()) {
suggestion: How would you feel about moving this optimization into a separate
helper? That way it would visually be clear that this is an optional
optimization, a comment in that regard might also be nice/

[titzer, 2014-10-31 12:44:28]

On 2014/10/31 12:28:06, Michael Starzinger wrote:
> Looking good, just one suggestion.
> 
>
https://codereview.chromium.org/694773002/diff/1/src/compiler/js-generic-lowe...
> File src/compiler/js-generic-lowering.cc (right):
> 
>
https://codereview.chromium.org/694773002/diff/1/src/compiler/js-generic-lowe...
> src/compiler/js-generic-lowering.cc:427: if (func.HasValue()) {
> suggestion: How would you feel about moving this optimization into a separate
> helper? That way it would visually be clear that this is an optional
> optimization, a comment in that regard might also be nice/

Done.

[Michael Starzinger, 2014-10-31 12:58:53]

LGTM.

https://codereview.chromium.org/694773002/diff/20001/src/compiler/js-generic-...
File src/compiler/js-generic-lowering.h (right):

https://codereview.chromium.org/694773002/diff/20001/src/compiler/js-generic-...
src/compiler/js-generic-lowering.h:70: bool TryLowerDirectJSCall(Node* node);
nit: C++ style guide wants fields after methods, I personally don't care.

[titzer, 2014-10-31 16:35:55]

Committed patchset #2 (id:20001) manually as 25042 (presubmit successful).