DevTools: Show preview for ES6 MapIterator, SetIterator in console.

DevTools: Show preview for ES6 MapIterator, SetIterator in console.

BUG=427868
R=yurys, vsevik

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185029

[aandrey, 2014-10-31 10:23:04]

Depends on https://codereview.chromium.org/693813002/ patch to V8.

[vsevik, 2014-10-31 15:02:03]

What happens if we do something like

m = new Map();
m.set(1,2);
m.set(2,3);
keys = m.keys();
keys.next();

and dump keys then?

Can we test this?

[aandrey, 2014-10-31 15:15:41]

On 2014/10/31 15:02:03, vsevik wrote:
> What happens if we do something like
> 
> m = new Map();
> m.set(1,2);
> m.set(2,3);
> keys = m.keys();
> keys.next();
> 
> and dump keys then?
> 
> Can we test this?

This is a part of V8 mirrors implementation and tested in the V8 patch.

[aandrey, 2014-11-01 09:58:56]

On 2014/10/31 15:02:03, vsevik wrote:
> What happens if we do something like
> 
> m = new Map();
> m.set(1,2);
> m.set(2,3);
> keys = m.keys();
> keys.next();
> 
> and dump keys then?
> 
> Can we test this?

Done.

[vsevik, 2014-11-06 07:10:52]

We could also show the original collection (map, set, etc) as well, this could
be useful when the iterator is already in the middle of the list and one wants
to see previous values.

[vsevik, 2014-11-06 07:13:43]

lgtm

[aandrey, 2014-11-06 20:58:06]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-11-06 20:58:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/694753002/60001

[commit-bot: I haz the power, 2014-11-06 21:01:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-06 21:01:54]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[aandrey, 2014-11-09 23:01:47]

The CQ bit was checked by aandrey@chromium.org

[aandrey, 2014-11-09 23:01:49]

The CQ bit was unchecked by aandrey@chromium.org

[yurys, 2014-11-10 07:31:34]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-11-10 07:31:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/694753002/60001

[commit-bot: I haz the power, 2014-11-10 07:34:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-10 07:34:49]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[yurys, 2014-11-10 07:38:02]

The CQ bit was checked by yurys@chromium.org

[yurys, 2014-11-10 07:38:03]

lgtm

https://codereview.chromium.org/694753002/diff/60001/Source/bindings/core/v8/...
File Source/bindings/core/v8/DebuggerScript.js (right):

https://codereview.chromium.org/694753002/diff/60001/Source/bindings/core/v8/...
Source/bindings/core/v8/DebuggerScript.js:88:
DebuggerScript.getCollectionEntries = function(object)
We should pick a better name for the method as not it accepts iterator too.

[commit-bot: I haz the power, 2014-11-10 07:38:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/694753002/60001

[commit-bot: I haz the power, 2014-11-10 09:31:49]

Committed patchset #4 (id:60001) as 185029