[WebMIDI] Fix code style to suppress a static analysis error.

[WebMIDI] Fix code style to suppress a static analysis error.

A static code analyzer reports an error in usb_midi_output_stream.cc, which
is a message_size_table buffer overflow. This CL fixes the code.
Note that the reported error never happens and hence the fix doesn't change
the behavior.

BUG=427616
Committed: https://crrev.com/84beeaa373ad30771120f533dc8d2c8f14524654
Cr-Commit-Position: refs/heads/master@{#302560}

[yhirano, 2014-10-31 06:06:21]

yhirano@chromium.org changed reviewers:
+ brucedawson@google.com, toyoshim@chromium.org

[yhirano, 2014-10-31 06:06:22]

PTAL

brucedawson@: fyi

[Takashi Toyoshima, 2014-10-31 07:13:37]

LGTM with two confirmation.
If it's intended, I'm fine to keep them as is.

https://codereview.chromium.org/694733002/diff/20001/media/midi/usb_midi_outp...
File media/midi/usb_midi_output_stream.cc (right):

https://codereview.chromium.org/694733002/diff/20001/media/midi/usb_midi_outp...
media/midi/usb_midi_output_stream.cc:122: // There are only 6 message types
(0xf1 - 0xf7), so we have the size table of
Is this place intended?
It sounds like a description on message_size_table at line 127.

https://codereview.chromium.org/694733002/diff/20001/media/midi/usb_midi_outp...
media/midi/usb_midi_output_stream.cc:168: // There are only 7 message types
(0x80 - 0xe0), so we have the size table
Same. Is this for message_size_table at line 172?

[yhirano, 2014-10-31 07:42:54]

https://codereview.chromium.org/694733002/diff/20001/media/midi/usb_midi_outp...
File media/midi/usb_midi_output_stream.cc (right):

https://codereview.chromium.org/694733002/diff/20001/media/midi/usb_midi_outp...
media/midi/usb_midi_output_stream.cc:122: // There are only 6 message types
(0xf1 - 0xf7), so we have the size table of
On 2014/10/31 07:13:37, Takashi Toyoshima (chromium) wrote:
> Is this place intended?
> It sounds like a description on message_size_table at line 127.

Done.

https://codereview.chromium.org/694733002/diff/20001/media/midi/usb_midi_outp...
media/midi/usb_midi_output_stream.cc:168: // There are only 7 message types
(0x80 - 0xe0), so we have the size table
On 2014/10/31 07:13:37, Takashi Toyoshima (chromium) wrote:
> Same. Is this for message_size_table at line 172?

Done.

[chromium-reviews, 2014-10-31 14:39:28]

The bug number we've been using for the /analyze finds is 427616, FWIW.

Thanks for the clarifying change.

On Fri, Oct 31, 2014 at 12:42 AM, <yhirano@chromium.org> wrote:

>
> https://codereview.chromium.org/694733002/diff/20001/
> media/midi/usb_midi_output_stream.cc
> File media/midi/usb_midi_output_stream.cc (right):
>
> https://codereview.chromium.org/694733002/diff/20001/
> media/midi/usb_midi_output_stream.cc#newcode122
> media/midi/usb_midi_output_stream.cc:122: // There are only 6 message
> types (0xf1 - 0xf7), so we have the size table of
> On 2014/10/31 07:13:37, Takashi Toyoshima (chromium) wrote:
>
>> Is this place intended?
>> It sounds like a description on message_size_table at line 127.
>>
>
> Done.
>
> https://codereview.chromium.org/694733002/diff/20001/
> media/midi/usb_midi_output_stream.cc#newcode168
> media/midi/usb_midi_output_stream.cc:168: // There are only 7 message
> types (0x80 - 0xe0), so we have the size table
> On 2014/10/31 07:13:37, Takashi Toyoshima (chromium) wrote:
>
>> Same. Is this for message_size_table at line 172?
>>
>
> Done.
>
> https://codereview.chromium.org/694733002/
>



-- 
Bruce Dawson

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[yhirano, 2014-11-04 01:38:55]

On 2014/10/31 14:39:28, chromium-reviews wrote:
> The bug number we've been using for the /analyze finds is 427616, FWIW.
> 
> Thanks for the clarifying change.
> 
> On Fri, Oct 31, 2014 at 12:42 AM, <mailto:yhirano@chromium.org> wrote:
> 
> >
> > https://codereview.chromium.org/694733002/diff/20001/
> > media/midi/usb_midi_output_stream.cc
> > File media/midi/usb_midi_output_stream.cc (right):
> >
> > https://codereview.chromium.org/694733002/diff/20001/
> > media/midi/usb_midi_output_stream.cc#newcode122
> > media/midi/usb_midi_output_stream.cc:122: // There are only 6 message
> > types (0xf1 - 0xf7), so we have the size table of
> > On 2014/10/31 07:13:37, Takashi Toyoshima (chromium) wrote:
> >
> >> Is this place intended?
> >> It sounds like a description on message_size_table at line 127.
> >>
> >
> > Done.
> >
> > https://codereview.chromium.org/694733002/diff/20001/
> > media/midi/usb_midi_output_stream.cc#newcode168
> > media/midi/usb_midi_output_stream.cc:168: // There are only 7 message
> > types (0x80 - 0xe0), so we have the size table
> > On 2014/10/31 07:13:37, Takashi Toyoshima (chromium) wrote:
> >
> >> Same. Is this for message_size_table at line 172?
> >>
> >
> > Done.
> >
> > https://codereview.chromium.org/694733002/
> >
> 
> 
> 
> -- 
> Bruce Dawson
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Thanks, done.

[yhirano, 2014-11-04 01:39:12]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2014-11-04 01:40:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/694733002/60001

[commit-bot: I haz the power, 2014-11-04 02:58:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-11-04 02:58:52]

Patchset 4 (id:??) landed as
https://crrev.com/84beeaa373ad30771120f533dc8d2c8f14524654
Cr-Commit-Position: refs/heads/master@{#302560}