Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: tests/Test.cpp

Issue 694703005: When running DM, write test failures to json. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Use "" instead of NULL Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/Test.h ('k') | tests/skia_test.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/Test.cpp
diff --git a/tests/Test.cpp b/tests/Test.cpp
index c458f897fbb20e673ddc421f4ef2f1348b5d9d18..acbc332936860ae9d5c196b706018156f2e34095 100644
--- a/tests/Test.cpp
+++ b/tests/Test.cpp
@@ -31,8 +31,8 @@ void Reporter::startTest(Test* test) {
this->onStart(test);
}
-void Reporter::reportFailed(const SkString& desc) {
- this->onReportFailed(desc);
+void Reporter::reportFailed(const skiatest::Failure& failure) {
+ this->onReportFailed(failure);
}
void Reporter::endTest(Test* test) {
@@ -63,11 +63,11 @@ public:
explicit LocalReporter(Reporter* reporterToMimic) : fReporter(reporterToMimic) {}
int numFailures() const { return fFailures.count(); }
- const SkString& failure(int i) const { return fFailures[i]; }
+ const skiatest::Failure& failure(int i) const { return fFailures[i]; }
protected:
- virtual void onReportFailed(const SkString& desc) SK_OVERRIDE {
- fFailures.push_back(desc);
+ virtual void onReportFailed(const Failure& failure) SK_OVERRIDE {
+ fFailures.push_back(failure);
}
// Proxy down to fReporter. We assume these calls are threadsafe.
@@ -85,7 +85,7 @@ protected:
private:
Reporter* fReporter; // Unowned.
- SkTArray<SkString> fFailures;
+ SkTArray<skiatest::Failure> fFailures;
};
void Test::run() {
« no previous file with comments | « tests/Test.h ('k') | tests/skia_test.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698