sky/engine/core/rendering/RenderBox.cpp - Issue 694703002: Remove lots of dead virtuals from Element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderBox.cpp

Issue 694703002: Remove lots of dead virtuals from Element. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderBox.cpp

diff --git a/sky/engine/core/rendering/RenderBox.cpp b/sky/engine/core/rendering/RenderBox.cpp

index b9e708956ad57416182554743a9754dc7ea3ed9a..4146dd3e25396e47b50ee54a09a83674369079bb 100644

--- a/sky/engine/core/rendering/RenderBox.cpp

+++ b/sky/engine/core/rendering/RenderBox.cpp

@@ -3456,8 +3456,8 @@ bool RenderBox::shrinkToAvoidFloats() const

static bool isReplacedElement(Node* node)

{

- // Checkboxes and radioboxes are not isReplaced() nor do they have their own renderer in which to override avoidFloats().

- return node && node->isElementNode() && toElement(node)->isFormControlElement();

+ // FIXME(sky): Remove this.

+ return false;

}

bool RenderBox::avoidsFloats() const