Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 694643002: Condition the nss and nspr build targets on use_openssl==0. (Closed)

Created:
6 years, 1 month ago by davidben
Modified:
6 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/nss.git@master
Project:
chromium
Visibility:
Public.

Description

Condition the nss and nspr build targets on use_openssl==0. Ensure that nothing can accidentally depend on NSS in a BoringSSL build. BUG=429021 R=rsleevi@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/292840

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1170 lines, -1164 lines) Patch
M nss.gyp View 2 chunks +1170 lines, -1164 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
davidben
Unfortunately, Rietveld's diff viewer is being incredibly useless and so it's not obvious that I ...
6 years, 1 month ago (2014-10-30 23:32:03 UTC) #2
Ryan Sleevi
LGTM
6 years, 1 month ago (2014-11-04 00:50:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694643002/1
6 years, 1 month ago (2014-11-04 00:54:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/87526) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/77187) win_gpu ...
6 years, 1 month ago (2014-11-04 01:00:11 UTC) #7
davidben
6 years, 1 month ago (2014-11-05 00:23:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 292840 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698