Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: build/common.gypi

Issue 694633002: Disable basic printing on ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fri Oct 31 10:04:51 PDT 2014 Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2898 matching lines...) Expand 10 before | Expand all | Expand 10 after
2909 'defines': ['CLD_VERSION=<(cld_version)'], 2909 'defines': ['CLD_VERSION=<(cld_version)'],
2910 }], 2910 }],
2911 ['cld_version==2', { 2911 ['cld_version==2', {
2912 # This is used to populate the "CLD Data Source" field in: 2912 # This is used to populate the "CLD Data Source" field in:
2913 # chrome://translate-internals 2913 # chrome://translate-internals
2914 'defines': ['CLD2_DATA_SOURCE=<(cld2_data_source)'], 2914 'defines': ['CLD2_DATA_SOURCE=<(cld2_data_source)'],
2915 }], 2915 }],
2916 ['enable_printing==1', { 2916 ['enable_printing==1', {
2917 'defines': ['ENABLE_FULL_PRINTING=1', 'ENABLE_PRINTING=1'], 2917 'defines': ['ENABLE_FULL_PRINTING=1', 'ENABLE_PRINTING=1'],
2918 }], 2918 }],
2919 ['enable_printing==1 and chromeos==1', {
2920 'defines': ['DISABLE_BASIC_PRINTING=1'],
Lei Zhang 2014/10/31 18:24:38 You probably want to add this to the GN version as
Vitaly Buka (NO REVIEWS) 2014/10/31 19:09:49 Done.
2921 }],
2919 ['enable_printing==2', { 2922 ['enable_printing==2', {
2920 'defines': ['ENABLE_PRINTING=1'], 2923 'defines': ['ENABLE_PRINTING=1'],
2921 }], 2924 }],
2922 ['enable_spellcheck==1', { 2925 ['enable_spellcheck==1', {
2923 'defines': ['ENABLE_SPELLCHECK=1'], 2926 'defines': ['ENABLE_SPELLCHECK=1'],
2924 }], 2927 }],
2925 ['enable_captive_portal_detection==1', { 2928 ['enable_captive_portal_detection==1', {
2926 'defines': ['ENABLE_CAPTIVE_PORTAL_DETECTION=1'], 2929 'defines': ['ENABLE_CAPTIVE_PORTAL_DETECTION=1'],
2927 }], 2930 }],
2928 ['enable_app_list==1', { 2931 ['enable_app_list==1', {
(...skipping 2950 matching lines...) Expand 10 before | Expand all | Expand 10 after
5879 # settings in target dicts. SYMROOT is a special case, because many other 5882 # settings in target dicts. SYMROOT is a special case, because many other
5880 # Xcode variables depend on it, including variables such as 5883 # Xcode variables depend on it, including variables such as
5881 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5884 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5882 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5885 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5883 # files to appear (when present) in the UI as actual files and not red 5886 # files to appear (when present) in the UI as actual files and not red
5884 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5887 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5885 # and therefore SYMROOT, needs to be set at the project level. 5888 # and therefore SYMROOT, needs to be set at the project level.
5886 'SYMROOT': '<(DEPTH)/xcodebuild', 5889 'SYMROOT': '<(DEPTH)/xcodebuild',
5887 }, 5890 },
5888 } 5891 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698