Profile unlock should always use session restore, regardless of system preference.

Profile unlock should always use session restore, regardless of system preference.

The UserManager will now set the ProfileInfoCache's "signin required" bit to false after the browser's opened rather than before, so that it can be read during startup.

BUG=420762
Committed: https://crrev.com/aa6da7f1cad568965c6b6bb30cc9103cfbdaee57
Cr-Commit-Position: refs/heads/master@{#302459}

[Mike Lerman, 2014-10-30 18:35:11]

mlerman@chromium.org changed reviewers:
+ bcwhite@chromium.org, msw@chromium.org

[Mike Lerman, 2014-10-30 18:35:12]

Hi Brian and Mike,

Can you please review this CL?

Brian - user_manager_screen_handler.cc
Mike - startup_browser_creator.cc

Thanks!

[bcwhite, 2014-10-30 19:39:44]

lgtm

https://codereview.chromium.org/694593002/diff/1/chrome/browser/ui/webui/sign...
File chrome/browser/ui/webui/signin/user_manager_screen_handler.cc (right):

https://codereview.chromium.org/694593002/diff/1/chrome/browser/ui/webui/sign...
chrome/browser/ui/webui/signin/user_manager_screen_handler.cc:725: // Unlock the
profile after browser opens so startup can read the lock bit.
Can you add something like "any authentication must have been successful to
reach this point"?

[msw, 2014-10-30 19:43:27]

lgtm

[Mike Lerman, 2014-10-30 20:15:43]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-10-30 20:17:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/694593002/20001

[commit-bot: I haz the power, 2014-10-30 20:43:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-30 20:43:23]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)

[Mike Lerman, 2014-10-30 21:01:43]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-10-30 21:03:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/694593002/20001

[commit-bot: I haz the power, 2014-10-30 21:24:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-30 21:24:44]

Try jobs failed on following builders:
  linux_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_trigger...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Mike Lerman, 2014-10-30 22:26:01]

Had to modify the startup_browser_creator because the Profile may not be in the
ProfileInfoCache. I had broken many tests.

Please take a second look. Thanks!

[msw, 2014-10-30 22:29:50]

lgtm with nits

https://codereview.chromium.org/694593002/diff/40001/chrome/browser/ui/startu...
File chrome/browser/ui/startup/startup_browser_creator.cc (right):

https://codereview.chromium.org/694593002/diff/40001/chrome/browser/ui/startu...
chrome/browser/ui/startup/startup_browser_creator.cc:398: // If called during
CreatePrimaryProfile on startup, |profile| has not yet
nit: not sure the comment is entirely necessary.

https://codereview.chromium.org/694593002/diff/40001/chrome/browser/ui/startu...
chrome/browser/ui/startup/startup_browser_creator.cc:404: pref.type =
SessionStartupPref::LAST;
nit: fix indent

[Mike Lerman, 2014-11-03 03:50:32]

Hi Mike,

There was an issue with a unit test that did not have a profile manager. I
changed the unit test - I think it's safe to assume in real code that we always
have a profile_manager. Can you please review the change?

Thanks,
Mike

[Mike Lerman, 2014-11-03 18:35:18]

Hi Mike,

I'm aiming to hit this week's dev channel, so I'm going to hit commit. If you
have any comments, I'll happily add them on after - let me know!

[Mike Lerman, 2014-11-03 18:35:22]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-11-03 18:35:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/694593002/100001

[commit-bot: I haz the power, 2014-11-03 19:17:26]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2014-11-03 19:18:24]

Patchset 6 (id:??) landed as
https://crrev.com/aa6da7f1cad568965c6b6bb30cc9103cfbdaee57
Cr-Commit-Position: refs/heads/master@{#302459}

[msw, 2014-11-03 19:27:55]

still lgtm