tools/metrics/histograms/histograms.xml - Issue 694573003: Domain Reliability: Histogram net error codes from uploads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 694573003: Domain Reliability: Histogram net error codes from uploads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Label upload response code histogram with an enum Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 4238c85d79551f4a5ec0e04a4147315b1bed189b..a145278e1d0c8fe2919033d39e4034631733f50f 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -5219,11 +5219,19 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

-<histogram name="DomainReliability.UploadResponseCode">

+<histogram name="DomainReliability.UploadNetError" enum="NetErrorCodes">

<owner>ttuttle@chromium.org</owner>

- The response code returned by the Domain Reliability collector when a report

- is uploaded.

+ The network error code (or OK if none) returned by the URLFetcher when a

+ Domain Reliability report is uploaded.

+ </summary>

+</histogram>

+<histogram name="DomainReliability.UploadResponseCode" enum="HttpResponseCode">

+ <owner>ttuttle@chromium.org</owner>

+ <summary>

+ The HTTP response code returned by the Domain Reliability collector when a

+ report is uploaded.

</summary>

</histogram>

« no previous file with comments | « components/domain_reliability/uploader.cc ('k') | no next file » | no next file with comments »