Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: chromeos/network/network_state.h

Issue 694533007: Add 'setProperties' to InternetOptionsHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_state.h
diff --git a/chromeos/network/network_state.h b/chromeos/network/network_state.h
index 91247b474f9e4c175f148d72ac794bbe6dff46c9..17a2aeb100af4626a98707cdaba8e92636750ad4 100644
--- a/chromeos/network/network_state.h
+++ b/chromeos/network/network_state.h
@@ -44,6 +44,10 @@ class CHROMEOS_EXPORT NetworkState : public ManagedState {
virtual void GetStateProperties(
base::DictionaryValue* dictionary) const override;
+ // Like GetStateProperties, but only sets properties needed for configuration
+ // i.e. no Strength or other properties associated only with visible networks.
+ void GetConfigurationStateProperties(base::DictionaryValue* dictionary) const;
+
void IPConfigPropertiesChanged(const base::DictionaryValue& properties);
// Returns true, if the network requires a service activation.
@@ -127,6 +131,14 @@ class CHROMEOS_EXPORT NetworkState : public ManagedState {
friend class NetworkStateHandler;
friend class NetworkChangeNotifierChromeosUpdateTest;
+ // Helper method for Get*Properties, gets network sepcific properties.
+ void GetNetworkStateProperties(base::DictionaryValue* dictionary) const;
+
+ // Helper method for GetStateProperties, gets additional properties
+ // associated with visible networks, e.g. Strength.
+ void GetVisibleStateProperties(base::DictionaryValue* dictionary) const;
+
+
// Updates |name_| from WiFi.HexSSID if provided, and validates |name_|.
// Returns true if |name_| changes.
bool UpdateName(const base::DictionaryValue& properties);

Powered by Google App Engine
This is Rietveld 408576698