Add 'setProperties' to InternetOptionsHandler

chrome/test/data/extensions/api_test/networking/test.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Note: the expectations in this test are shared by both the Chrome OS and
 // Win/Mac (ServiceClient) implementations. TODO(stevenjb): Set up a way for
 // the test code to specify the correct expectations.
 
 var callbackPass = chrome.test.callbackPass;
 var callbackFail = chrome.test.callbackFail;
@@ skipping 362 matching lines @@
                  }, result);
       }));
   },
   function setProperties() {
     var done = chrome.test.callbackAdded();
     var network_guid = "stub_wifi2_guid";
     chrome.networkingPrivate.getProperties(
         network_guid,
         callbackPass(function(result) {
           assertEq(network_guid, result.GUID);
-          result.WiFi.Security = "WEP-PSK";
+          var new_properties = {};

[pneubeck (no reviews), 2014/11/13 17:38:56]

wouldn't
var new_properties = {
  Priority: 1,
  WiFi: {
    AutoConnect: true
  }
};

be much easier to read an the javascript-way?
(alternative with the keys in quotes)

[stevenjb, 2014/11/13 22:25:41]

Yeah, probably. What can i say, I'm still a C++ programmer at heart.

[pneubeck (no reviews), 2014/11/14 08:17:02]

:-)

+          new_properties['Priority'] = 1;
+          var wifi = {};
+          wifi['AutoConnect']= true;
+          new_properties['WiFi'] = wifi;
           chrome.networkingPrivate.setProperties(
               network_guid,
-              result,
+              new_properties,
               callbackPass(function() {
                 chrome.networkingPrivate.getProperties(
                     network_guid,
                     callbackPass(function(result) {
-                      // Ensure that the property was set.
-                      assertEq("WEP-PSK", result.WiFi.Security);
+                      // Ensure that the properties were set.
+                      assertEq(1, result['Priority']);
+                      assertEq(true, result['WiFi']['AutoConnect']);
                       // Ensure that the GUID doesn't change.
                       assertEq(network_guid, result.GUID);
                       done();
                     }));
               }));
         }));
   },
   function getState() {
     chrome.networkingPrivate.getState(
       "stub_wifi2_guid",
@@ skipping 108 matching lines @@
         new privateHelpers.watchForCaptivePortalState(
             'wifi_guid', 'Online', done);
     chrome.test.sendMessage('notifyPortalDetectorObservers');
   },
 ];
 
 var testToRun = window.location.search.substring(1);
 chrome.test.runTests(availableTests.filter(function(op) {
   return op.name == testToRun;
 }));