Add 'setProperties' to InternetOptionsHandler

chrome/browser/resources/options/chromeos/internet_detail.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: onc_data.js
 
 // NOTE(stevenjb): This code is in the process of being converted to be
 // compatible with the networkingPrivate extension API:
 // * The network property dictionaries are being converted to use ONC values.
 // * chrome.send calls will be replaced with an API object that simulates the
@@ skipping 70 matching lines @@
   }
 
   /**
    * @param {string} action An action to send to coreOptionsUserMetricsAction.
    */
   function sendChromeMetricsAction(action) {
     chrome.send('coreOptionsUserMetricsAction', [action]);
   }
 
   /**
-   * Sends the 'checked' state of a control to chrome for a network.
-   * @param {string} path The service path of the network.
-   * @param {string} message The message to send to chrome.
-   * @param {string} checkboxId The id of the checkbox with the value to send.
-   * @param {string=} opt_action Optional action to record.
-   */
-  function sendCheckedIfEnabled(path, message, checkboxId, opt_action) {
-    var checkbox = assertInstanceof($(checkboxId), HTMLInputElement);
-    if (!checkbox.hidden && !checkbox.disabled) {
-      chrome.send(message, [path, !!checkbox.checked]);
-      if (opt_action)
-        sendChromeMetricsAction(opt_action);
-    }
-  }
-
-  /**
    * Send metrics to Chrome when the detailed page is opened.
    * @param {string} type The ONC type of the network being shown.
    * @param {string} state The ONC network state.
    */
   function sendShowDetailsMetrics(type, state) {
     if (type == 'WiFi') {
       sendChromeMetricsAction('Options_NetworkShowDetailsWifi');
       if (state != 'NotConnected')
         sendChromeMetricsAction('Options_NetworkShowDetailsWifiConnected');
     } else if (type == 'Cellular') {
@@ skipping 962 matching lines @@
   };
 
   /**
    * Event handler called when the details page is closed. Sends changed
    * properties to Chrome and closes the overlay.
    */
   DetailsInternetPage.setDetails = function() {
     var detailsPage = DetailsInternetPage.getInstance();
     var type = detailsPage.type_;
     var servicePath = detailsPage.servicePath_;
+    var oncData = new OncData({});
+    var autoConnectCheckboxId = '';
     if (type == 'WiFi') {
-      sendCheckedIfEnabled(servicePath,
-                           'setPreferNetwork',
-                           'prefer-network-wifi',
-                           'Options_NetworkSetPrefer');
-      sendCheckedIfEnabled(servicePath,
-                           'setAutoConnect',
-                           'auto-connect-network-wifi',
-                           'Options_NetworkAutoConnect');
+      var preferredCheckbox =
+          assertInstanceof($('prefer-network-wifi'), HTMLInputElement);
+      if (!preferredCheckbox.hidden && !preferredCheckbox.disabled) {
+        var kPreferredPriority = 1;
+        var priority = preferredCheckbox.checked ? kPreferredPriority : 0;
+        oncData.setManagedProperty('Priority', priority);

[pneubeck (no reviews), 2014/11/18 13:21:38]

this shouldn't create a managed dictionary.
SetProperties expects an un-managed ONC dictionary and this function name
indicates the opposite.

[stevenjb, 2014/11/18 23:12:06]

Yes, that is poorly named, it explicitly only sets unmanaged properties. I
renamed it to just 'OncData.setProperty'.

+        sendChromeMetricsAction('Options_NetworkSetPrefer');
+      }
+      autoConnectCheckboxId = 'auto-connect-network-wifi';
     } else if (type == 'WiMAX') {
-      sendCheckedIfEnabled(servicePath,
-                           'setAutoConnect',
-                           'auto-connect-network-wimax',
-                           'Options_NetworkAutoConnect');
+      autoConnectCheckboxId = 'auto-connect-network-wimax';
     } else if (type == 'Cellular') {
-      sendCheckedIfEnabled(servicePath,
-                           'setAutoConnect',
-                           'auto-connect-network-cellular',
-                           'Options_NetworkAutoConnect');
+      autoConnectCheckboxId = 'auto-connect-network-cellular';
     } else if (type == 'VPN') {
-      chrome.send('setServerHostname',
-                  [servicePath, $('inet-server-hostname').value]);
-      sendCheckedIfEnabled(servicePath,
-                           'setAutoConnect',
-                           'auto-connect-network-vpn',
-                           'Options_NetworkAutoConnect');
+      oncData.setManagedProperty('VPN.Host', $('inet-server-hostname').value);
+      autoConnectCheckboxId = 'auto-connect-network-vpn';
+    }
+    if (autoConnectCheckboxId != '') {
+      var autoConnectCheckbox =
+          assertInstanceof($(autoConnectCheckboxId), HTMLInputElement);
+      if (!autoConnectCheckbox.hidden && !autoConnectCheckbox.disabled) {
+        var autoConnectKey = type + '.AutoConnect';
+        oncData.setManagedProperty(autoConnectKey,
+                                   !!autoConnectCheckbox.checked);
+        sendChromeMetricsAction('Options_NetworkAutoConnect');
+      }
     }
 
     var nameServerTypes = ['automatic', 'google', 'user'];
     var nameServerType = 'automatic';
     for (var i = 0; i < nameServerTypes.length; ++i) {
       if ($(nameServerTypes[i] + '-dns-radio').checked) {
         nameServerType = nameServerTypes[i];
         break;
       }
     }
     detailsPage.sendIpConfig_(nameServerType);
 
+    var data = oncData.getData();
+    if (Object.keys(data).length > 0) {
+      // TODO(stevenjb): chrome.networkingPrivate.setProperties
+      chrome.send('setProperties', [servicePath, data]);
+    }
+
     PageManager.closeOverlay();
   };
 
   /**
    * Event handler called when the name server type changes.
    * @param {string} type The selected name sever type, 'automatic', 'google',
    *                      or 'user'.
    */
   DetailsInternetPage.updateNameServerDisplay = function(type) {
     var editable = type == 'user';
@@ skipping 458 matching lines @@
 
     // Don't show page name in address bar and in history to prevent people
     // navigate here by hand and solve issue with page session restore.
     PageManager.showPageByName('detailsInternetPage', false);
   };
 
   return {
     DetailsInternetPage: DetailsInternetPage
   };
 });