Allow all font weights on Android and respect overrides.

Allow all font weights on Android and respect overrides.

This removes the code which forces 400 and 700 weights only,
and also overrides the font weight with the configured weight.

Committed: https://skia.googlesource.com/skia/+/4b86bacb0428b07cba01fd46452d5c46e6f21af0

[bungeman-skia, 2014-10-30 20:31:29]

bungeman@google.com changed reviewers:
+ djsollen@google.com, tomhudson@google.com

[tomhudson, 2014-10-31 14:06:12]

It'll be good to see those hacks go, but we put them in for a purpose - don't we
break all sorts of Android expectations without them? Where are the
corresponding changes?

[tomhudson, 2014-10-31 14:06:23]

On 2014/10/31 14:06:12, tomhudson wrote:
> It'll be good to see those hacks go, but we put them in for a purpose - don't
we
> break all sorts of Android expectations without them? Where are the
> corresponding changes?

(Where's the bug?)

[djsollen, 2014-10-31 14:22:01]

needs a suppressions file

[bungeman-skia, 2014-10-31 14:33:57]

On 2014/10/31 14:06:12, tomhudson wrote:
> It'll be good to see those hacks go, but we put them in for a purpose - don't
we
> break all sorts of Android expectations without them? Where are the
> corresponding changes?

I don't think this breaks anything anywhere. All existing code is still calling
through legacyCreateTypeface which uses only the bold/italic bits, so they won't
see any changes. This change simply means we aren't blocking anyone from using
the new fonts with the new interface.

[djsollen, 2014-10-31 14:40:45]

On 2014/10/31 14:33:57, bungeman1 wrote:
> On 2014/10/31 14:06:12, tomhudson wrote:
> > It'll be good to see those hacks go, but we put them in for a purpose -
don't
> we
> > break all sorts of Android expectations without them? Where are the
> > corresponding changes?
> 
> I don't think this breaks anything anywhere. All existing code is still
calling
> through legacyCreateTypeface which uses only the bold/italic bits, so they
won't
> see any changes. This change simply means we aren't blocking anyone from using
> the new fonts with the new interface.

then why does the bot fail on the font_mgr gm?

[bungeman-skia, 2014-10-31 14:43:28]

On 2014/10/31 14:40:45, djsollen wrote:
> On 2014/10/31 14:33:57, bungeman1 wrote:
> > On 2014/10/31 14:06:12, tomhudson wrote:
> > > It'll be good to see those hacks go, but we put them in for a purpose -
> don't
> > we
> > > break all sorts of Android expectations without them? Where are the
> > > corresponding changes?
> > 
> > I don't think this breaks anything anywhere. All existing code is still
> calling
> > through legacyCreateTypeface which uses only the bold/italic bits, so they
> won't
> > see any changes. This change simply means we aren't blocking anyone from
using
> > the new fonts with the new interface.
> 
> then why does the bot fail on the font_mgr gm?

Because it uses the new interface. The change there is expected and correct.

[bungeman-skia, 2014-11-04 18:29:10]

At PS4 expectations have been added.

[djsollen, 2014-11-04 18:36:31]

lgtm.  should we land this after the branch point?

[tomhudson, 2014-11-04 18:42:56]

lgtm

[bungeman-skia, 2014-11-04 18:45:49]

On 2014/11/04 18:36:31, djsollen wrote:
> lgtm.  should we land this after the branch point?

This change doesn't appear to affect Blink on Android at all at the moment, and
it also shouldn't change the current usage on Android. All it really does is
make things nicer if they ever start using the new interface. And I have a whole
two days to revert :-)

[bungeman-skia, 2014-11-04 18:45:54]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2014-11-04 18:46:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/694533006/60001

[djsollen, 2014-11-04 18:46:55]

It will only affect devices running on L, which I don't know that they have bot
coverage for yet.

[bungeman-skia, 2014-11-04 18:52:20]

On 2014/11/04 18:46:55, djsollen wrote:
> It will only affect devices running on L, which I don't know that they have
bot
> coverage for yet.

Currently it doesn't affect anyone (it would affect both K and L if they were
using the new interface), this code was just here as a work-around until
https://codereview.chromium.org/488143002 landed.

[commit-bot: I haz the power, 2014-11-04 18:54:36]

Committed patchset #4 (id:60001) as 4b86bacb0428b07cba01fd46452d5c46e6f21af0