Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 694533004: Add return value on GrRecordReplaceDraw (Closed)

Created:
6 years, 1 month ago by robertphillips
Modified:
6 years, 1 month ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add return value on GrRecordReplaceDraw This assists debugging layer hoisting errors (e.g., when a layer is hoisted but not actually used in subsequent rendering). Committed: https://skia.googlesource.com/skia/+/0882fdcc15f81bbaf66421dc7934c2893726a3da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -18 lines) Patch
M src/gpu/GrRecordReplaceDraw.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 6 chunks +21 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
robertphillips
6 years, 1 month ago (2014-10-30 17:50:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694533004/1
6 years, 1 month ago (2014-10-30 18:04:00 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-10-30 18:04:00 UTC) #5
egdaniel
lgtm
6 years, 1 month ago (2014-10-30 18:13:15 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 18:54:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 0882fdcc15f81bbaf66421dc7934c2893726a3da

Powered by Google App Engine
This is Rietveld 408576698