Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 694533003: Add FLAG_trace_maps (Closed)

Created:
6 years, 1 month ago by Jakob Kummerow
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+456 lines, -76 lines) Patch
M Makefile View 1 1 chunk +4 lines, -0 lines 0 comments Download
M build/features.gypi View 1 2 chunks +5 lines, -0 lines 0 comments Download
M build/toolchain.gypi View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/api.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 8 chunks +19 lines, -7 lines 0 comments Download
M src/factory.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/isolate.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/objects.h View 1 13 chunks +38 lines, -10 lines 0 comments Download
M src/objects.cc View 1 36 chunks +142 lines, -46 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects-printer.cc View 1 1 chunk +34 lines, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-literals.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 5 chunks +7 lines, -5 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
A tools/trace-maps-processor.py View 1 2 1 chunk +172 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jakob Kummerow
PTAL.
6 years, 1 month ago (2014-11-07 14:03:16 UTC) #2
Toon Verwaest
lgtm
6 years, 1 month ago (2014-11-07 14:29:51 UTC) #3
Jakob Kummerow
6 years, 1 month ago (2014-11-07 16:03:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 25219 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698