Cleanup android to ensure it can compile with clang

Cleanup android to ensure it can compile with clang

Committed: https://skia.googlesource.com/skia/+/a3a706fcd4cc9376a1223a53f57589f29d4a36ea

[djsollen, 2014-10-30 14:57:38]

djsollen@google.com changed reviewers:
+ borenet@google.com, tomhudson@chromium.org

[djsollen, 2014-10-30 14:58:06]

https://codereview.chromium.org/694533002/diff/1/gyp/opts.gyp
File gyp/opts.gyp (left):

https://codereview.chromium.org/694533002/diff/1/gyp/opts.gyp#oldcode75
gyp/opts.gyp:75: '-mno-apcs-frame',
this is the default on gcc and is not supported on clang

[tomhudson, 2014-10-30 15:18:44]

lgtm

[tomhudson, 2014-10-30 15:19:14]

Wasn't there a different issue pointed out internally? Or did you already fix
that and this is follow-up?

[djsollen, 2014-10-30 16:26:29]

The CQ bit was checked by djsollen@google.com

[djsollen, 2014-10-30 16:27:00]

On 2014/10/30 15:19:14, tomhudson wrote:
> Wasn't there a different issue pointed out internally? Or did you already fix
> that and this is follow-up?

This is just so we can get to a point where we can repro that issue.

[commit-bot: I haz the power, 2014-10-30 16:27:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/694533002/1

[tfarina, 2014-10-30 16:59:34]

https://codereview.chromium.org/694533002/diff/1/include/views/SkOSWindow_And...
File include/views/SkOSWindow_Android.h (right):

https://codereview.chromium.org/694533002/diff/1/include/views/SkOSWindow_And...
include/views/SkOSWindow_Android.h:15: struct SkIRect;
You can also just remove this forward declaration as it comes from SkWindow.

You can also do the same for include/views/SkOSWindow_NaCl.h

[commit-bot: I haz the power, 2014-10-30 18:39:17]

Committed patchset #1 (id:1) as a3a706fcd4cc9376a1223a53f57589f29d4a36ea