Updating WebM canPlayType Layout Tests to check VP9

Updating WebM canPlayType Layout Tests to check VP9

Updating the Layout Tests for WebM canPlayType to make sure vp9
returns "probably"

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161934

[scherkus (not reviewing), 2013-11-11 21:36:36]

https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
File LayoutTests/media/media-can-play-webm.html (right):

https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
LayoutTests/media/media-can-play-webm.html:13:
testExpected("video.canPlayType('video/webm; codecs=vp8,vorbis')", "probably");
think you can add another case for vp8 by itself?

https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
LayoutTests/media/media-can-play-webm.html:15:
testExpected("video.canPlayType('video/webm; codecs=vp9')", "probably");
hrmm.. we should probably be exercising vp9 and vp9+vorbis and (when it gets
there) vp9+opus

[vignesh, 2013-11-11 23:58:16]

https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
File LayoutTests/media/media-can-play-webm.html (right):

https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
LayoutTests/media/media-can-play-webm.html:13:
testExpected("video.canPlayType('video/webm; codecs=vp8,vorbis')", "probably");
On 2013/11/11 21:36:36, scherkus wrote:
> think you can add another case for vp8 by itself?

Done.

https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
LayoutTests/media/media-can-play-webm.html:15:
testExpected("video.canPlayType('video/webm; codecs=vp9')", "probably");
On 2013/11/11 21:36:36, scherkus wrote:
> hrmm.. we should probably be exercising vp9 and vp9+vorbis and (when it gets
> there) vp9+opus

Done. Will add the opus and vp9+opus tests after we flip the flag on opus
playback

[scherkus (not reviewing), 2013-11-12 00:02:12]

On 2013/11/11 23:58:16, vignesh wrote:
>
https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
> File LayoutTests/media/media-can-play-webm.html (right):
> 
>
https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
> LayoutTests/media/media-can-play-webm.html:13:
> testExpected("video.canPlayType('video/webm; codecs=vp8,vorbis')",
"probably");
> On 2013/11/11 21:36:36, scherkus wrote:
> > think you can add another case for vp8 by itself?
> 
> Done.
> 
>
https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
> LayoutTests/media/media-can-play-webm.html:15:
> testExpected("video.canPlayType('video/webm; codecs=vp9')", "probably");
> On 2013/11/11 21:36:36, scherkus wrote:
> > hrmm.. we should probably be exercising vp9 and vp9+vorbis and (when it gets
> > there) vp9+opus
> 
> Done. Will add the opus and vp9+opus tests after we flip the flag on opus
> playback

Well actually what's neat about an expectations file is that we can add opus
today with the expectation that it's not supported.

When you add in your opus changes the test will start reporting a mismatch in
expectations, which will then be a strong signal that we should update the
expectations.

[fgalligan1, 2013-11-12 01:00:52]

On 2013/11/12 00:02:12, scherkus wrote:
> On 2013/11/11 23:58:16, vignesh wrote:
> >
>
https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
> > File LayoutTests/media/media-can-play-webm.html (right):
> > 
> >
>
https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
> > LayoutTests/media/media-can-play-webm.html:13:
> > testExpected("video.canPlayType('video/webm; codecs=vp8,vorbis')",
> "probably");
> > On 2013/11/11 21:36:36, scherkus wrote:
> > > think you can add another case for vp8 by itself?
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
> > LayoutTests/media/media-can-play-webm.html:15:
> > testExpected("video.canPlayType('video/webm; codecs=vp9')", "probably");
> > On 2013/11/11 21:36:36, scherkus wrote:
> > > hrmm.. we should probably be exercising vp9 and vp9+vorbis and (when it
gets
> > > there) vp9+opus
> > 
> > Done. Will add the opus and vp9+opus tests after we flip the flag on opus
> > playback
> 
> Well actually what's neat about an expectations file is that we can add opus
> today with the expectation that it's not supported.
> 
> When you add in your opus changes the test will start reporting a mismatch in
> expectations, which will then be a strong signal that we should update the
> expectations.

While you are at it, can you add "vp8.0" == "probably", "vp8.1" == "", "vp9.0"
== "probably", "vp9.1" == ""?

[vignesh, 2013-11-12 15:58:23]

On 2013/11/12 01:00:52, fgalligan1 wrote:
> On 2013/11/12 00:02:12, scherkus wrote:
> > On 2013/11/11 23:58:16, vignesh wrote:
> > >
> >
>
https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
> > > File LayoutTests/media/media-can-play-webm.html (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
> > > LayoutTests/media/media-can-play-webm.html:13:
> > > testExpected("video.canPlayType('video/webm; codecs=vp8,vorbis')",
> > "probably");
> > > On 2013/11/11 21:36:36, scherkus wrote:
> > > > think you can add another case for vp8 by itself?
> > > 
> > > Done.
> > > 
> > >
> >
>
https://codereview.chromium.org/69453002/diff/1/LayoutTests/media/media-can-p...
> > > LayoutTests/media/media-can-play-webm.html:15:
> > > testExpected("video.canPlayType('video/webm; codecs=vp9')", "probably");
> > > On 2013/11/11 21:36:36, scherkus wrote:
> > > > hrmm.. we should probably be exercising vp9 and vp9+vorbis and (when it
> gets
> > > > there) vp9+opus
> > > 
> > > Done. Will add the opus and vp9+opus tests after we flip the flag on opus
> > > playback
> > 
> > Well actually what's neat about an expectations file is that we can add opus
> > today with the expectation that it's not supported.
> > 
> > When you add in your opus changes the test will start reporting a mismatch
in
> > expectations, which will then be a strong signal that we should update the
> > expectations.

Done.

> 
> While you are at it, can you add "vp8.0" == "probably", "vp8.1" == "", "vp9.0"
> == "probably", "vp9.1" == ""?

Done.

[scherkus (not reviewing), 2013-11-12 21:17:22]

lgtm

[commit-bot: I haz the power, 2013-11-13 16:06:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vigneshv@chromium.org/69453002/130001

[commit-bot: I haz the power, 2013-11-13 17:34:45]

Change committed as 161934