util/net/http_multipart_builder_test.cc - Issue 694483002: Treat '+' as a safe MIME type character.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/net/http_multipart_builder_test.cc

Issue 694483002: Treat '+' as a safe MIME type character. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/net/http_multipart_builder_test.cc

diff --git a/util/net/http_multipart_builder_test.cc b/util/net/http_multipart_builder_test.cc

index 4367e9cc2aafab1b3fa050a0182eb04fb8ea4548..b4fae5b83740c2fec61b838e0aabfec783504f8b 100644

--- a/util/net/http_multipart_builder_test.cc

+++ b/util/net/http_multipart_builder_test.cc

@@ -257,6 +257,8 @@ TEST(HTTPMultipartBuilder, AssertUnsafeMIMEType) {

ASSERT_DEATH(builder.SetFileAttachment("", "", base::FilePath(), "<>"), "");

// Invalid but safe:

builder.SetFileAttachment("", "", base::FilePath(), "0/totally/-invalid.pdf");

+ // Valid and safe:

+ builder.SetFileAttachment("", "", base::FilePath(), "application/xml+xhtml");

}

} // namespace

« no previous file with comments | « util/net/http_multipart_builder.cc ('k') | no next file » | no next file with comments »