Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 694463002: Revert of Update mojo sdk to rev e083961bf11fd0c94d40be8853761da529b6d444 (Closed)

Created:
6 years, 1 month ago by binjin
Modified:
6 years, 1 month ago
Reviewers:
jamesr, Aaron Boodman
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Update mojo sdk to rev e083961bf11fd0c94d40be8853761da529b6d444 (patchset #6 id:120001 of https://codereview.chromium.org/683583002/) Reason for revert: Suspected to cause android bot failures: New warnings. Please fix, or perhaps add to /b/build/slave/Android_Builder__dbg_/build/src/build/android/findbugs_filter/findbugs_known_bugs.txt -------------------------------------------------------------------------------- M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.imported.ImportedInterface_Internal$ImportedInterfaceDoSomethingParams.equals(Object) At ImportedInterface_Internal.java M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.math.Calculator_Internal$CalculatorClearParams.equals(Object) At Calculator_Internal.java M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.mojo.IntegrationTestInterface2_Internal$IntegrationTestInterface2Method0Params.equals(Object) At IntegrationTestInterface2_Internal.java M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithParameterAndEmptyResponseResponseParams.equals(Object) At CheckMethodWithEmptyResponse_Internal.java M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithouParameterAndEmptyResponseParams.equals(Object) At CheckMethodWithEmptyResponse_Internal.java M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.CheckMethodWithEmptyResponse_Internal$CheckMethodWithEmptyResponseWithouParameterAndEmptyResponseResponseParams.equals(Object) At CheckMethodWithEmptyResponse_Internal.java M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.regression_tests.EmptyStruct.equals(Object) At EmptyStruct.java M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.sample.NamedObject_Internal$NamedObjectGetNameParams.equals(Object) At NamedObject_Internal.java M D DLS: Dead store to other in org.chromium.mojo.bindings.test.mojom.test_structs.EmptyStruct.equals(Object) At EmptyStruct.java -------------------------------------------------------------------------------- *** 9 FindBugs warnings! *** *** 9: new *** Original issue's description: > Update mojo sdk to rev e083961bf11fd0c94d40be8853761da529b6d444 > > TBR=jam@chromium.org > > Committed: https://crrev.com/37273cab357d03ad9d2bcfa4ae467567ce93e2c4 > Cr-Commit-Position: refs/heads/master@{#302038} TBR=jamesr@chromium.org,aa@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6b7fc0b1e9ce197220ce0453843461c8cc950ab0 Cr-Commit-Position: refs/heads/master@{#302066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -1353 lines) Patch
M content/common/geolocation_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M content/common/render_frame_setup.mojom View 1 chunk +1 line, -1 line 0 comments Download
M device/battery/battery_monitor.mojom View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/data_stream_serialization.mojom View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial.mojom View 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_serialization.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M media/mojo/interfaces/demuxer_stream.mojom View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/media_renderer.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/channel_endpoint.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/edk/system/channel_endpoint.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M mojo/public/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/application/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
M mojo/public/cpp/application/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/public/cpp/application/application_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/cpp/application/application_test_base.h View 1 chunk +0 lines, -50 lines 0 comments Download
M mojo/public/cpp/application/lib/DEPS View 1 chunk +1 line, -4 lines 0 comments Download
M mojo/public/cpp/application/lib/application_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D mojo/public/cpp/application/lib/application_test_base.cc View 1 chunk +0 lines, -94 lines 0 comments Download
M mojo/public/gles2/BUILD.gn View 1 chunk +1 line, -5 lines 0 comments Download
M mojo/public/go/system/core.go View 1 chunk +11 lines, -69 lines 0 comments Download
M mojo/public/go/system/impl/core_impl.go View 1 chunk +2 lines, -95 lines 0 comments Download
D mojo/public/go/system/impl/mojo_types.go View 1 chunk +0 lines, -212 lines 0 comments Download
M mojo/public/interfaces/application/application.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/application/shell.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_factory.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_import2.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_service.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_structs.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java View 3 chunks +3 lines, -59 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/MessageHeader.java View 1 chunk +13 lines, -4 lines 0 comments Download
M mojo/public/js/bindings/core_unittests.js View 2 chunks +0 lines, -15 lines 0 comments Download
M mojo/public/python/mojo/bindings/messaging.py View 5 chunks +3 lines, -11 lines 0 comments Download
M mojo/public/python/mojo/bindings/promise.py View 3 chunks +1 line, -9 lines 0 comments Download
M mojo/public/python/mojo/bindings/reflection.py View 6 chunks +1 line, -354 lines 0 comments Download
M mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl View 2 chunks +0 lines, -60 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_java_generator.py View 1 chunk +6 lines, -8 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_python_generator.py View 8 chunks +7 lines, -44 lines 0 comments Download
M mojo/public/tools/bindings/generators/python_templates/module.py.tmpl View 2 chunks +24 lines, -25 lines 0 comments Download
M mojo/public/tools/bindings/generators/python_templates/module_macros.tmpl View 1 chunk +0 lines, -28 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py View 4 chunks +5 lines, -15 lines 0 comments Download
M mojo/services/public/cpp/native_viewport/args.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/services/public/cpp/native_viewport/lib/args.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/content_handler/content_handler.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/gpu/gpu.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/input_events/input_events.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/navigation/navigation.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/network/network_service.mojom View 1 chunk +8 lines, -8 lines 0 comments Download
M mojo/services/public/interfaces/network/tcp_bound_socket.mojom View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/tcp_server_socket.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/public/interfaces/network/udp_socket.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/network/url_loader.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/network/web_socket.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/surfaces/quads.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/surfaces.mojom View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/surfaces_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/services/public/interfaces/window_manager/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/public/interfaces/window_manager/window_manager.mojom View 2 chunks +24 lines, -2 lines 0 comments Download
D mojo/services/public/interfaces/window_manager/window_manager_internal.mojom View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
binjin
Created Revert of Update mojo sdk to rev e083961bf11fd0c94d40be8853761da529b6d444
6 years, 1 month ago (2014-10-30 10:43:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694463002/1
6 years, 1 month ago (2014-10-30 10:44:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 10:45:42 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 10:46:20 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b7fc0b1e9ce197220ce0453843461c8cc950ab0
Cr-Commit-Position: refs/heads/master@{#302066}

Powered by Google App Engine
This is Rietveld 408576698