Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: sky/engine/core/dom/Element.h

Issue 694443003: Devirtualize a bunch of Element. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/Element.h
diff --git a/sky/engine/core/dom/Element.h b/sky/engine/core/dom/Element.h
index 68fc5904eb1de5af34d0a04e027b5818f49230a0..ce6395d986099b0a9ab4723329a9cfb6e8f02ca1 100644
--- a/sky/engine/core/dom/Element.h
+++ b/sky/engine/core/dom/Element.h
@@ -150,14 +150,14 @@ public:
int clientTop();
int clientWidth();
int clientHeight();
- virtual int scrollLeft();
- virtual int scrollTop();
- virtual void setScrollLeft(int);
- virtual void setScrollLeft(const Dictionary& scrollOptionsHorizontal, ExceptionState&);
- virtual void setScrollTop(int);
- virtual void setScrollTop(const Dictionary& scrollOptionsVertical, ExceptionState&);
- virtual int scrollWidth();
- virtual int scrollHeight();
+ int scrollLeft();
+ int scrollTop();
+ void setScrollLeft(int);
+ void setScrollLeft(const Dictionary& scrollOptionsHorizontal, ExceptionState&);
+ void setScrollTop(int);
+ void setScrollTop(const Dictionary& scrollOptionsVertical, ExceptionState&);
+ int scrollWidth();
+ int scrollHeight();
PassRefPtr<ClientRectList> getClientRects();
PassRefPtr<ClientRect> getBoundingClientRect();
@@ -282,9 +282,9 @@ public:
virtual const AtomicString imageSourceURL() const;
virtual Image* imageContents() { return 0; }
- virtual void focus(bool restorePreviousSelection = true, FocusType = FocusTypeNone);
- virtual void updateFocusAppearance(bool restorePreviousSelection);
- virtual void blur();
+ void focus(bool restorePreviousSelection = true, FocusType = FocusTypeNone);
+ void updateFocusAppearance(bool restorePreviousSelection);
+ void blur();
// Whether this element can receive focus at all. Most elements are not
// focusable but some elements, such as form controls and links, are. Unlike
// rendererIsFocusable(), this method may be called when layout is not up to
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698