Issue 694413003: Add mojo_launcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 694413003: Add mojo_launcher (Closed)

Created:
6 years, 1 month ago by DaveMoore

Modified:
6 years, 1 month ago

Reviewers:
Chris Masone

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add mojo_launcher BUG= R=cmasone@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3d6a17f6e3264c3086452b125678f98f5e603ddc

Patch Set 2 : Minor cleanup #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -13 lines)			Patch
M	mojo/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/application_manager/application_manager.cc	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	mojo/shell/BUILD.gn	View	1	5 chunks	+30 lines, -11 lines	1 comment	Download
M	mojo/shell/incoming_connection_listener_posix.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A	mojo/shell/launcher_main.cc	View		1 chunk	+113 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Chris Masone

lgtm https://codereview.chromium.org/694413003/diff/20001/mojo/shell/BUILD.gn File mojo/shell/BUILD.gn (right): https://codereview.chromium.org/694413003/diff/20001/mojo/shell/BUILD.gn#newcode57 mojo/shell/BUILD.gn:57: "//mojo/gles2", Is this going to remain necessary always, ...

6 years, 1 month ago (2014-11-04 01:35:34 UTC) #4

DaveMoore

6 years, 1 month ago (2014-11-04 03:30:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3d6a17f6e3264c3086452b125678f98f5e603ddc (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 694413003: Add mojo_launcher (Closed)

Description

Patch Set 1 #

Patch Set 2 : Minor cleanup #

Messages