Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 694393002: Land Recent QUIC Changes. (Closed)

Created:
6 years, 1 month ago by ramant (doing other things)
Modified:
6 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, alyssar, Ian Swett, rjshade, Jana
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes. Tiny refactor of QuicSentPacketManager::NetworkChangeVisitor's OnCongestionWindowChange() method to take no arguments, and require the caller to fetch the updated congestion window. Slightly simplifies the code. In preparation for the larger GetCongestionWindowInPackets() cleanup. Merge internal change: 78883300 https://codereview.chromium.org/694383002/ Change the number of emulated connections in QUIC's congestion control as the number of open streams changes when the NCON connection option is supplied. Merge internal change: 78876869 https://codereview.chromium.org/682293004/ Merge changes to keep chromium source tree same as internal source tree. Merge internal change: 78853598 https://codereview.chromium.org/693253002/ QUIC: Only send a new SCUP if enough packets have been sent since the last SCUP. Merge internal change: 78841268 https://codereview.chromium.org/699433002/ Fixes reduction for n-connection emulation in TCP Reno. Merge internal change: 78812645 https://codereview.chromium.org/680253005/ Delay a QUIC server's use of the FORWARD_SECURE encrypter until the client has had a chance to start using it. Protected by FLAGS_enable_quic_delay_forward_security. When the forward secure encrypter is available, don't use it until one of two things happens: 1) the peers starts sending forward secure encrypted packets 2) 2 round trips worth of packets have been sent, in case something (MitM?) is preventing the peer from using forward secure encryption. Merge internal change: 78801773 Set FLAGS_enable_quic_delay_forward_security to true in chromium. https://codereview.chromium.org/698703003/ Change QUIC's Reno congestion controller to use a higher beta. Fixed tests to be independent of beta. Merge internal change: 78728349 https://codereview.chromium.org/698713002/ R=rch@chromium.org Committed: https://crrev.com/33da8ab021168895957e45ad4d1af9e991a2c665 Cr-Commit-Position: refs/heads/master@{#302571}

Patch Set 1 #

Patch Set 2 : set FLAGS_enable_quic_delay_forward_security to true #

Patch Set 3 : minor comment fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -173 lines) Patch
M net/quic/congestion_control/tcp_cubic_sender.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 4 chunks +12 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 12 chunks +58 lines, -63 lines 0 comments Download
M net/quic/crypto/common_cert_set.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_connection.h View 1 2 6 chunks +16 lines, -5 lines 0 comments Download
M net/quic/quic_connection.cc View 6 chunks +37 lines, -2 lines 0 comments Download
M net/quic/quic_connection_test.cc View 2 chunks +60 lines, -1 line 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 3 chunks +4 lines, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 2 6 chunks +16 lines, -5 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 18 chunks +40 lines, -58 lines 0 comments Download
M net/quic/quic_server_session.h View 1 2 2 chunks +8 lines, -5 lines 0 comments Download
M net/quic/quic_server_session.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M net/quic/quic_session.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_client_session.h View 2 chunks +5 lines, -5 lines 0 comments Download
M net/tools/quic/quic_server_session.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/tools/quic/quic_server_session.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ramant (doing other things)
6 years, 1 month ago (2014-11-03 18:08:56 UTC) #1
ramant (doing other things)
Hi Ryan, If changes look good, will land this CL after this week's Dev branch ...
6 years, 1 month ago (2014-11-03 18:10:24 UTC) #2
Ryan Hamilton
lgtm
6 years, 1 month ago (2014-11-03 18:13:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694393002/60001
6 years, 1 month ago (2014-11-04 01:12:10 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:60001)
6 years, 1 month ago (2014-11-04 04:17:08 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 04:17:43 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/33da8ab021168895957e45ad4d1af9e991a2c665
Cr-Commit-Position: refs/heads/master@{#302571}

Powered by Google App Engine
This is Rietveld 408576698