Issue 694383002: Tiny refactor of QuicSentPacketManager::NetworkChangeVisitor's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 694383002: Tiny refactor of QuicSentPacketManager::NetworkChangeVisitor's (Closed)

Created:
6 years, 1 month ago by ramant (doing other things)

Modified:
6 years, 1 month ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@Change_number_of_emulated_connections_78876869

Project:
chromium

Visibility:
Public.

More Reviews

Description

Tiny refactor of QuicSentPacketManager::NetworkChangeVisitor's OnCongestionWindowChange() method to take no arguments, and require the caller to fetch the updated congestion window. Slightly simplifies the code. In preparation for the larger GetCongestionWindowInPackets() cleanup. Merge internal change: 78883300 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -71 lines)			Patch
M	net/quic/quic_connection.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_connection.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	net/quic/quic_packet_generator.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/quic_sent_packet_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager_test.cc	View	20 chunks	+24 lines, -61 lines	0 comments	Download
M	net/quic/test_tools/quic_test_utils.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages