Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: src/compiler/change-lowering.cc

Issue 694353006: [turbofan] Fix branch hints for ChangeInt32ToTagged and ChangeTaggedToUI32. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/change-lowering.cc
diff --git a/src/compiler/change-lowering.cc b/src/compiler/change-lowering.cc
index 0b4a39952ae69bab681a32ac0d590a986f8ab9cd..f2968db78c0c34e4d08dd04f77e565f984dc3579 100644
--- a/src/compiler/change-lowering.cc
+++ b/src/compiler/change-lowering.cc
@@ -143,7 +143,7 @@ Reduction ChangeLowering::ChangeInt32ToTagged(Node* val, Node* control) {
Node* ovf = graph()->NewNode(common()->Projection(1), add);
Node* branch =
- graph()->NewNode(common()->Branch(BranchHint::kTrue), ovf, control);
+ graph()->NewNode(common()->Branch(BranchHint::kFalse), ovf, control);
Node* if_true = graph()->NewNode(common()->IfTrue(), branch);
Node* heap_number = AllocateHeapNumberWithValue(
@@ -167,7 +167,8 @@ Reduction ChangeLowering::ChangeTaggedToUI32(Node* val, Node* control,
Node* tag = graph()->NewNode(machine()->WordAnd(), val,
jsgraph()->IntPtrConstant(kSmiTagMask));
- Node* branch = graph()->NewNode(common()->Branch(), tag, control);
+ Node* branch =
+ graph()->NewNode(common()->Branch(BranchHint::kFalse), tag, control);
Node* if_true = graph()->NewNode(common()->IfTrue(), branch);
const Operator* op = (signedness == kSigned)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698