athena: Expose the list of activities from the ActivityManager.

athena/activity/public/activity_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ATHENA_ACTIVITY_PUBLIC_ACTIVITY_MANAGER_H_
 #define ATHENA_ACTIVITY_PUBLIC_ACTIVITY_MANAGER_H_
 
+#include <vector>
+
 #include "athena/athena_export.h"
 
 namespace aura {
 class Window;
 }
 
 namespace athena {
 
 class Activity;
 class ActivityManagerObserver;
 
+using ActivityList = std::vector<Activity*>;
+
 // Manages a set of activities.
 class ATHENA_EXPORT ActivityManager {
  public:
   static ActivityManager* Create();
   static ActivityManager* Get();
   static void Shutdown();
 
   virtual ~ActivityManager() {}
 
   // Adds/Removes an activity. ActivityManager owns the activities.
   virtual void AddActivity(Activity* activity) = 0;
   virtual void RemoveActivity(Activity* activity) = 0;
 
+  // Updates the UI when the task color/title changes.
+  virtual void UpdateActivity(Activity* activity) = 0;

[oshima, 2014/11/04 00:26:03]

off topic: I think we should get rid of this and replace with better mechanism.
WDTY?

[sadrul, 2014/11/04 03:43:46]

One option is to introduce an ActivityViewModelObserver interface that notifies
of title/icon/color changes, and the ActivityManagerImpl installs itself as an
observer to all the activity-models in the activity-list.

+
+  // Returns a list of activities, sorted in their activation order (the most
+  // recently used activity is at the front of the returned list).
+  virtual const ActivityList& GetActivities() = 0;

[oshima, 2014/11/04 00:26:03]

I was just thinking something similiar for different purpose, thanks!

Would you mind using GetActivityList to emphasize it's ordered and also it
matches the type.

[sadrul, 2014/11/04 03:43:46]

Done.

+
   // Returns the activity that has a |window| as toplevel window, or
   // nullptr if such activity does not exist.
   virtual Activity* GetActivityForWindow(aura::Window* window) = 0;
 
-  // Updates the UI when the task color/title changes.
-  virtual void UpdateActivity(Activity* activity) = 0;
-
   virtual void AddObserver(ActivityManagerObserver* observer) = 0;
   virtual void RemoveObserver(ActivityManagerObserver* observer) = 0;
 };
 
 }  // namespace athena
 
 #endif  // ATHENA_ACTIVITY_PUBLIC_ACTIVITY_MANAGER_H_