build/toolchain/win/BUILD.gn - Issue 694353003: Get `gn gen` to succeed on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/toolchain/win/BUILD.gn

Issue 694353003: Get `gn gen` to succeed on Windows (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: remove GYP_DEFINES code Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/toolchain/win/BUILD.gn

diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn

index a9fab7c4c03c422f9384ea48ce19404879015be6..85fbf6286e23aeb11c1559a225cb10b10e6cb8a1 100644

--- a/build/toolchain/win/BUILD.gn

+++ b/build/toolchain/win/BUILD.gn

@@ -13,7 +13,7 @@ assert(is_win)

# Its arguments are the VS path and the compiler wrapper tool. It will write

# "environment.x86" and "environment.x64" to the build directory and return a

# list to us.

-gyp_win_tool_path = rebase_path("//tools/gyp/pylib/gyp/win_tool.py",

+gyp_win_tool_path = rebase_path("//build/win/win_tool.py",

root_build_dir)

exec_script("setup_toolchain.py",

[ visual_studio_path, gyp_win_tool_path, windows_sdk_path ])

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | build/vs_toolchain.py » ('j') | no next file with comments »