Issue 694263004: Fix windows GN build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 694263004: Fix windows GN build (Closed)

Created:
6 years, 1 month ago by Dirk Pranke

Modified:
6 years, 1 month ago

Reviewers:
scottmg

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Fix windows GN build Fix the reference to the sanitizers to not be needed on windows, and remove a stray reference to a file that doesn't exist any more. TBR=brettw@chromium.org, scottmg@chromium.org BUG= Committed: https://crrev.com/0ae1ae5d64fa7691ce7856bf9e4eab4d9bb576ec Cr-Commit-Position: refs/heads/master@{#302677}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	build/config/compiler/BUILD.gn	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	net/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694263004/1

6 years, 1 month ago (2014-11-04 20:45:03 UTC) #4

commit-bot: I haz the power

6 years, 1 month ago (2014-11-04 21:32:08 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0ae1ae5d64fa7691ce7856bf9e4eab4d9bb576ec
Cr-Commit-Position: refs/heads/master@{#302677}