scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json - Issue 694263003: Enable post-compile test isolation for all CI builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json

Issue 694263003: Enable post-compile test isolation for all CI builders. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json ('k') | scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json b/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json

index 3c366a2dfed5eac18e4bb3ed7db69e98599e29b3..2d23089b9ef08ca1891b557bff01f4789b8ea787 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json

@@ -99,7 +99,7 @@

"runhooks"

"env": {

- "GYP_DEFINES": "chromium_win_pch=0 component=shared_library fastbuild=1 gomadir='[BUILD]\\goma' target_arch=ia32 test_isolation_mode=archive test_isolation_outdir=https://isolateserver.appspot.com use_goma=1"

+ "GYP_DEFINES": "chromium_win_pch=0 component=shared_library fastbuild=1 gomadir='[BUILD]\\goma' target_arch=ia32 test_isolation_mode=prepare use_goma=1"

"name": "gclient runhooks"

@@ -206,13 +206,16 @@

"cmd": [

"python",

"-u",

- "[BUILD]\\scripts\\slave\\recipe_modules\\isolate\\resources\\find_isolated_tests.py",

- "--build-dir",

- "[SLAVE_BUILD]\\src\\out\\Debug",

- "--output-json",

- "/path/to/tmp/json"

+ "[SLAVE_BUILD]\\src\\tools\\swarming_client\\isolate.py",

+ "batcharchive",

+ "--dump-json",

+ "/path/to/tmp/json",

+ "--isolate-server",

+ "https://isolateserver.appspot.com",

+ "--verbose",

+ "[SLAVE_BUILD]\\src\\out\\Debug\\browser_tests.isolated.gen.json"

- "name": "find isolated tests",

+ "name": "isolate tests",

"~followup_annotations": [

"@@@STEP_LOG_LINE@json.output@{@@@",

"@@@STEP_LOG_LINE@json.output@ \"browser_tests\": \"[dummy hash for browser_tests]\"@@@",