Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 694253003: win: pull gyp for gn generation (Closed)

Created:
6 years, 1 month ago by scottmg
Modified:
6 years, 1 month ago
Reviewers:
jamesr, jam
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

win: pull gyp for gn generation and #if out some code that causes "unreachable code" warning on windows. TBR=jam@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/8f63fa97b4593f77d240d346efd78773827b539c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M DEPS View 1 chunk +5 lines, -3 lines 0 comments Download
M mojo/common/data_pipe_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
scottmg
pull gyp replaces the build/ changes in previous attempts. looks like other things were broken ...
6 years, 1 month ago (2014-11-07 17:32:36 UTC) #1
scottmg
Committed patchset #1 (id:1) manually as 8f63fa97b4593f77d240d346efd78773827b539c.
6 years, 1 month ago (2014-11-07 17:58:29 UTC) #2
jamesr
Why do you have to pull gyp?
6 years, 1 month ago (2014-11-07 18:01:17 UTC) #4
scottmg
On 2014/11/07 18:01:17, jamesr wrote: > Why do you have to pull gyp? GN uses ...
6 years, 1 month ago (2014-11-07 18:20:12 UTC) #5
jamesr
Yeah but that's a bug that needs to be fixed in chromium as well, right?
6 years, 1 month ago (2014-11-07 18:22:21 UTC) #6
scottmg
6 years, 1 month ago (2014-11-07 18:25:27 UTC) #7
Message was sent while issue was closed.
On 2014/11/07 18:22:21, jamesr wrote:
> Yeah but that's a bug that needs to be fixed in chromium as well, right?

I guess, but it's not going to get changed any time soon.

Powered by Google App Engine
This is Rietveld 408576698