Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5505)

Unified Diff: chrome/renderer/printing/print_web_view_helper_linux.cc

Issue 694213002: Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code duplication Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/printing/print_web_view_helper_linux.cc
diff --git a/chrome/renderer/printing/print_web_view_helper_linux.cc b/chrome/renderer/printing/print_web_view_helper_linux.cc
index a3014eab7b95f692e477781b465578b048479a57..8012ae530edfed45a1ea3b722bc31efdeee416c8 100644
--- a/chrome/renderer/printing/print_web_view_helper_linux.cc
+++ b/chrome/renderer/printing/print_web_view_helper_linux.cc
@@ -158,19 +158,14 @@ void PrintWebViewHelper::PrintPageInternal(
gfx::Rect content_area;
GetPageSizeAndContentAreaFromPageLayout(page_layout_in_points, &page_size,
&content_area);
- gfx::Rect canvas_area =
- params.params.display_header_footer ? gfx::Rect(page_size) : content_area;
-
- SkBaseDevice* device = metafile->StartPageForVectorCanvas(page_size,
- canvas_area,
- scale_factor);
- if (!device)
+ gfx::Rect canvas_area = gfx::Rect(page_size); // Allow drawing on
+ // entire page.
+ skia::RefPtr<skia::VectorCanvas> canvas =
+ metafile->GetVectorCanvasForNewPage(page_size, canvas_area, scale_factor);
+ if (!canvas.get()) {
return;
+ }
- // The printPage method take a reference to the canvas we pass down, so it
- // can't be a stack object.
- skia::RefPtr<skia::VectorCanvas> canvas =
- skia::AdoptRef(new skia::VectorCanvas(device));
MetafileSkiaWrapper::SetMetafileOnCanvas(*canvas, metafile);
skia::SetIsDraftMode(*canvas, is_print_ready_metafile_sent_);
@@ -187,6 +182,7 @@ void PrintWebViewHelper::PrintPageInternal(
}
RenderPageContent(frame, params.page_number, canvas_area, content_area,
scale_factor, canvas.get());
+ canvas.clear();
Vitaly Buka (NO REVIEWS) 2014/11/03 20:03:29 can you make "clear" use consistent? also webview
reed1 2014/11/03 20:29:33 What is meant by this?
Vitaly Buka (NO REVIEWS) 2014/11/03 20:50:11 here canvas.clear(); is used to reset canvas befor
hal.canary 2014/11/04 15:30:35 Done.
// Done printing. Close the device context to retrieve the compiled metafile.
if (!metafile->FinishPage())

Powered by Google App Engine
This is Rietveld 408576698