cc: Ensure that eviction tiling range is sane.

cc: Ensure that eviction tiling range is sane.

Currently our code assumes that high res tiling comes before the low
res tiling (for eviction iterators). However, that doesn't seem to be
the case in all situations. Rather that just fixing the problem (if
it is a problem), this patch makes the eviction code be able to proceed
without crashing. In these situations the eviction order of tilings
won't be ideal, but would still visit all tilings.

BUG=429397, 429201
R=danakj, reveman

Committed: https://crrev.com/b4ec0e9e4bad8c45402d2f39fe46aa38bfd03920
Cr-Commit-Position: refs/heads/master@{#302394}

[vmpstr, 2014-11-01 02:04:43]

ptal

[reveman, 2014-11-01 12:25:35]

lgtm after adding missing break statements

https://codereview.chromium.org/694143002/diff/1/cc/resources/picture_layer_t...
File cc/resources/picture_layer_tiling_set.cc (right):

https://codereview.chromium.org/694143002/diff/1/cc/resources/picture_layer_t...
cc/resources/picture_layer_tiling_set.cc:362: range = low_res_range;
missing a break statement here

https://codereview.chromium.org/694143002/diff/1/cc/resources/picture_layer_t...
cc/resources/picture_layer_tiling_set.cc:364: range =
TilingRange(low_res_range.end, tilings_.size());
and I think you should add a break statement here too even though that's not
technically needed

[vmpstr, 2014-11-01 18:08:50]

https://codereview.chromium.org/694143002/diff/1/cc/resources/picture_layer_t...
File cc/resources/picture_layer_tiling_set.cc (right):

https://codereview.chromium.org/694143002/diff/1/cc/resources/picture_layer_t...
cc/resources/picture_layer_tiling_set.cc:362: range = low_res_range;
On 2014/11/01 12:25:34, reveman wrote:
> missing a break statement here

Done.

https://codereview.chromium.org/694143002/diff/1/cc/resources/picture_layer_t...
cc/resources/picture_layer_tiling_set.cc:364: range =
TilingRange(low_res_range.end, tilings_.size());
On 2014/11/01 12:25:34, reveman wrote:
> and I think you should add a break statement here too even though that's not
> technically needed

Done.

[vmpstr, 2014-11-01 20:13:17]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-11-01 20:14:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/694143002/20001

[commit-bot: I haz the power, 2014-11-01 21:04:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-01 21:04:42]

Patchset 2 (id:??) landed as
https://crrev.com/b4ec0e9e4bad8c45402d2f39fe46aa38bfd03920
Cr-Commit-Position: refs/heads/master@{#302394}