include/v8.h - Issue 69413002: Fix compilation with GCC 4.8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/v8.h

Issue 69413002: Fix compilation with GCC 4.8 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: only use __attribute__ when supported Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/v8.h

diff --git a/include/v8.h b/include/v8.h

index 1f8cbfd83b0e0986336b9b0bcef6985d0659a4ef..d3471c55914b3c74aa0cf7cf53618f60b7292359 100644

--- a/include/v8.h

+++ b/include/v8.h

@@ -5819,7 +5819,6 @@ void ReturnValue<T>::Set(int32_t i) {

template<typename T>

void ReturnValue<T>::Set(uint32_t i) {

TYPE_CHECK(T, Integer);

- typedef internal::Internals I;

// Can't simply use INT32_MAX here for whatever reason.

bool fits_into_int32_t = (i & (1U << 31)) == 0;

if (V8_LIKELY(fits_into_int32_t)) {

« no previous file with comments | « no previous file | include/v8config.h » ('j') | no next file with comments »