Service Worker Cache: Simplify exception/rejection processing

Service Worker Cache: Simplify exception/rejection processing

Rather than explicitly catching exceptions and generating promise
rejections, let the bindings code do the work.

R=jkarlin
BUG=392621
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184886

[jsbell, 2014-10-31 23:06:19]

jkarlin@ - PTAL?

Addresses the FIXMEs in the code, and seems to simplify things.

https://codereview.chromium.org/694083002/diff/1/Source/modules/serviceworker...
File Source/modules/serviceworkers/CacheTest.cpp (right):

https://codereview.chromium.org/694083002/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/CacheTest.cpp:265: NonThrowableExceptionState
exceptionState;
Should I make this a member of the fixture instead? Private, with an accessor?
I'm not sure if that's better than making it explicit and local, though.

[jsbell, 2014-11-03 18:19:01]

I should note this is low priority.

I was looking at the new Union support in bindings, which we could adopt but
also makes the code messier. With this change in place, though, we can refactor
the methods to get something much cleaner than we have even now. But might as
well land this bit first if it looks good.

Again, no rush, and we can wait for after the branch point.

[jkarlin, 2014-11-03 18:51:05]

lgtm, though I'd prefer the exceptionstate to be a member in the tests.

https://codereview.chromium.org/694083002/diff/1/Source/modules/serviceworker...
File Source/modules/serviceworkers/CacheTest.cpp (right):

https://codereview.chromium.org/694083002/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/CacheTest.cpp:265: NonThrowableExceptionState
exceptionState;
On 2014/10/31 23:06:19, jsbell wrote:
> Should I make this a member of the fixture instead? Private, with an accessor?
> I'm not sure if that's better than making it explicit and local, though.

I'm in favor of making it a private member as it's used in several tests.

[jsbell, 2014-11-05 23:12:56]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-11-05 23:14:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/694083002/20001

[commit-bot: I haz the power, 2014-11-06 00:08:57]

Committed patchset #2 (id:20001) as 184886