Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 694073002: Autofill - fix for Lowes mobile checkout cc form (Closed)

Created:
6 years, 1 month ago by Evan Stade
Modified:
6 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Autofill - fix for Lowes mobile checkout cc form Recognize input type="password" for CVC field BUG=429343 Committed: https://crrev.com/bc7acfc27311c25129780ccf9c2c56698f475d00 Cr-Commit-Position: refs/heads/master@{#302467}

Patch Set 1 #

Patch Set 2 : relative #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M chrome/test/data/autofill/heuristics/output/22_checkout_m_lowes.com.out View 1 1 chunk +5 lines, -5 lines 0 comments Download
M components/autofill/core/browser/credit_card_field.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/form_field.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/form_field.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
6 years, 1 month ago (2014-10-31 22:39:47 UTC) #2
Ilya Sherman
LGTM
6 years, 1 month ago (2014-10-31 22:41:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694073002/20001
6 years, 1 month ago (2014-11-03 18:30:54 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-03 19:47:03 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 19:47:36 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bc7acfc27311c25129780ccf9c2c56698f475d00
Cr-Commit-Position: refs/heads/master@{#302467}

Powered by Google App Engine
This is Rietveld 408576698