Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: snapshot/system_snapshot.h

Issue 694063003: Add MinidumpSystemInfoWriter::InitializeFromSnapshot() and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/snapshot.gyp ('k') | snapshot/test/test_system_snapshot.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/system_snapshot.h
diff --git a/snapshot/system_snapshot.h b/snapshot/system_snapshot.h
index 6dfede6870f7b62b47b6fb0db468372dd2bc30c1..7a41227c84a0405ee0d2699a8f4f2a3038fe9301 100644
--- a/snapshot/system_snapshot.h
+++ b/snapshot/system_snapshot.h
@@ -79,8 +79,11 @@ class SystemSnapshot {
//! \brief Returns the snapshot system’s CPU revision.
//!
//! For x86-family CPUs (including x86_64 and 32-bit x86), this is the CPU
- //! family ID value from `cpuid 1` `eax`, adjusted to take the extended family
- //! ID into account.
+ //! family, model, and stepping ID values from `cpuid 1` `eax`. The family and
+ //! model values are adjusted to take the extended family and model IDs into
+ //! account. These values are encoded in this method’s return value with the
+ //! family in the high high 16 bits, the model in the next 8 bits, and the
+ //! stepping in the low 8 bits.
//!
//! \return A CPU architecture-specific value identifying the CPU revision.
virtual uint32_t CPURevision() const = 0;
« no previous file with comments | « snapshot/snapshot.gyp ('k') | snapshot/test/test_system_snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698