Add MinidumpSystemInfoWriter::InitializeFromSnapshot() and its test

Add MinidumpSystemInfoWriter::InitializeFromSnapshot() and its test.

TEST=minidump_test MinidumpSystemInfo*
R=rsesek@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8609cdb60da86f2c5fa2df31f9df7d5f0af0a371

[Mark Mentovai, 2014-10-31 22:06:39]

mark@chromium.org changed reviewers:
+ rsesek@chromium.org

[Mark Mentovai, 2014-11-02 15:10:46]

Patchset #2 (id:20001) has been deleted

[Robert Sesek, 2014-11-05 18:35:37]

https://codereview.chromium.org/694063003/diff/60001/minidump/minidump_system...
File minidump/minidump_system_info_writer.cc (right):

https://codereview.chromium.org/694063003/diff/60001/minidump/minidump_system...
minidump/minidump_system_info_writer.cc:73: } else if (cpu_architecture ==
kMinidumpCPUArchitectureAMD64) {
Make this body a private method, it's long enough, and it's hard to see where it
ends because of the macros?

https://codereview.chromium.org/694063003/diff/60001/minidump/minidump_system...
File minidump/minidump_system_info_writer_test.cc (right):

https://codereview.chromium.org/694063003/diff/60001/minidump/minidump_system...
minidump/minidump_system_info_writer_test.cc:280: EXPECT_LE(kCPUFamily, 270);
What's the point of these checks, up to line 285?

[Mark Mentovai, 2014-11-05 19:08:41]

Thanks, updated.

https://codereview.chromium.org/694063003/diff/60001/minidump/minidump_system...
File minidump/minidump_system_info_writer_test.cc (right):

https://codereview.chromium.org/694063003/diff/60001/minidump/minidump_system...
minidump/minidump_system_info_writer_test.cc:280: EXPECT_LE(kCPUFamily, 270);
On 2014/11/05 18:35:37, Robert Sesek wrote:
> What's the point of these checks, up to line 285?

Added a comment.

[Robert Sesek, 2014-11-05 20:12:15]

LGTM

[Mark Mentovai, 2014-11-05 23:10:44]

Committed patchset #4 (id:80001) manually as
8609cdb60da86f2c5fa2df31f9df7d5f0af0a371 (presubmit successful).