Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 694063002: Work around a parameter-unused-but-set warning in gin/ (Closed)

Created:
6 years, 1 month ago by Chris Masone
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Work around a parameter-unused-but-set warning in gin/ GCC thinks that the create_flags parameter in the templated class gin::Invoker constructor is going unused, even though it is definitely being used as a part of a variadic template expansion. Convince GCC that it is in fact being used by casting it to a void. BUG=424334 TEST=Linux GN build of gin with is_clang=false R=aa Committed: https://crrev.com/a34136a3c2eeefab5e700633e317ecb1428602de Cr-Commit-Position: refs/heads/master@{#302361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M gin/function_template.h View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Chris Masone
6 years, 1 month ago (2014-10-31 21:47:20 UTC) #2
Aaron Boodman
lgtm
6 years, 1 month ago (2014-10-31 22:11:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694063002/1
6 years, 1 month ago (2014-10-31 23:13:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-01 00:10:55 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 00:11:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a34136a3c2eeefab5e700633e317ecb1428602de
Cr-Commit-Position: refs/heads/master@{#302361}

Powered by Google App Engine
This is Rietveld 408576698