Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 694053002: Adds dependency on sanitizer (Closed)

Created:
6 years, 1 month ago by sky
Modified:
6 years, 1 month ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds dependency on sanitizer The santizer target is empty if no sanitizers are defined, otherwise it contains the necessary targets. Because of this we can always depend on it. Without this dep asan builds fail. BUG=none TEST=none R=brettw@chromium.org TBR=brettw@chromium.org Committed: https://crrev.com/b816da5b4e0433f12366f27abe2ba0223c5e8583 Cr-Commit-Position: refs/heads/master@{#302346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/xdisplaycheck/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sky
TBRing as this is trivial change.
6 years, 1 month ago (2014-10-31 21:35:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694053002/1
6 years, 1 month ago (2014-10-31 21:36:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 23:09:05 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 23:09:44 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b816da5b4e0433f12366f27abe2ba0223c5e8583
Cr-Commit-Position: refs/heads/master@{#302346}

Powered by Google App Engine
This is Rietveld 408576698