Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4034)

Unified Diff: chrome/browser/about_flags.cc

Issue 693963003: Add minimum TLS version control to about:flags and Finch gate it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ... Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index e0b7c08707e6b37d4cad0e26be32e6d2198c7a73..bb6b1e648281003e4068cfd3899948f8e8aafbcb 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -473,6 +473,18 @@ const Experiment::Choice kAutofillSyncCredentialChoices[] = {
password_manager::switches::kDisallowAutofillSyncCredential, ""},
};
+const Experiment::Choice kSSLVersionMinChoices[] = {
+ { IDS_FLAGS_SSL_VERSION_DEFAULT, switches::kSSLVersionMin, "" },
+ { IDS_FLAGS_SSL_VERSION_SSLV3, switches::kSSLVersionMin,
+ switches::kSSLVersionSSLv3 },
+ { IDS_FLAGS_SSL_VERSION_TLSV1, switches::kSSLVersionMin,
+ switches::kSSLVersionTLSv1 },
+ { IDS_FLAGS_SSL_VERSION_TLSV11, switches::kSSLVersionMin,
+ switches::kSSLVersionTLSv11 },
+ { IDS_FLAGS_SSL_VERSION_TLSV12, switches::kSSLVersionMin,
+ switches::kSSLVersionTLSv12 },
+};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the experiment is the internal name. If you'd like to
@@ -2021,6 +2033,13 @@ const Experiment kExperiments[] = {
SINGLE_VALUE_TYPE(chromeos::switches::kDisableNewZIPUnpacker)
}
#endif // defined(OS_CHROMEOS)
+ {
+ "ssl-version-min",
+ IDS_FLAGS_SSL_VERSION_MIN_NAME,
+ IDS_FLAGS_SSL_VERSION_MIN_DESCRIPTION,
+ kOsAll,
+ MULTI_VALUE_TYPE(kSSLVersionMinChoices)
+ },
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.

Powered by Google App Engine
This is Rietveld 408576698