Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 693963003: Add minimum TLS version control to about:flags and Finch gate it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ... Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 455 matching lines...) Expand 10 before | Expand all | Expand 10 after
466 const Experiment::Choice kAutofillSyncCredentialChoices[] = { 466 const Experiment::Choice kAutofillSyncCredentialChoices[] = {
467 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""}, 467 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
468 { IDS_ALLOW_AUTOFILL_SYNC_CREDENTIAL, 468 { IDS_ALLOW_AUTOFILL_SYNC_CREDENTIAL,
469 password_manager::switches::kAllowAutofillSyncCredential, ""}, 469 password_manager::switches::kAllowAutofillSyncCredential, ""},
470 { IDS_DISALLOW_AUTOFILL_SYNC_CREDENTIAL_FOR_REAUTH, 470 { IDS_DISALLOW_AUTOFILL_SYNC_CREDENTIAL_FOR_REAUTH,
471 password_manager::switches::kDisallowAutofillSyncCredentialForReauth, ""}, 471 password_manager::switches::kDisallowAutofillSyncCredentialForReauth, ""},
472 { IDS_DISALLOW_AUTOFILL_SYNC_CREDENTIAL, 472 { IDS_DISALLOW_AUTOFILL_SYNC_CREDENTIAL,
473 password_manager::switches::kDisallowAutofillSyncCredential, ""}, 473 password_manager::switches::kDisallowAutofillSyncCredential, ""},
474 }; 474 };
475 475
476 const Experiment::Choice kSSLVersionMinChoices[] = {
477 { IDS_FLAGS_SSL_VERSION_DEFAULT, "", "" },
478 { IDS_FLAGS_SSL_VERSION_SSLV3, switches::kSSLVersionMin,
479 switches::kSSLVersionSSLv3 },
480 { IDS_FLAGS_SSL_VERSION_TLSV1, switches::kSSLVersionMin,
481 switches::kSSLVersionTLSv1 },
482 { IDS_FLAGS_SSL_VERSION_TLSV11, switches::kSSLVersionMin,
483 switches::kSSLVersionTLSv11 },
484 { IDS_FLAGS_SSL_VERSION_TLSV12, switches::kSSLVersionMin,
485 switches::kSSLVersionTLSv12 },
486 };
487
476 // RECORDING USER METRICS FOR FLAGS: 488 // RECORDING USER METRICS FOR FLAGS:
477 // ----------------------------------------------------------------------------- 489 // -----------------------------------------------------------------------------
478 // The first line of the experiment is the internal name. If you'd like to 490 // The first line of the experiment is the internal name. If you'd like to
479 // gather statistics about the usage of your flag, you should append a marker 491 // gather statistics about the usage of your flag, you should append a marker
480 // comment to the end of the feature name, like so: 492 // comment to the end of the feature name, like so:
481 // "my-special-feature", // FLAGS:RECORD_UMA 493 // "my-special-feature", // FLAGS:RECORD_UMA
482 // 494 //
483 // After doing that, run 495 // After doing that, run
484 // tools/metrics/actions/extract_actions.py 496 // tools/metrics/actions/extract_actions.py
485 // to add the metric to actions.xml (which will enable UMA to record your 497 // to add the metric to actions.xml (which will enable UMA to record your
(...skipping 1524 matching lines...) Expand 10 before | Expand all | Expand 10 after
2010 IDS_FLAGS_ENABLE_REMOTE_ASSISTANCE_DESCRIPTION, 2022 IDS_FLAGS_ENABLE_REMOTE_ASSISTANCE_DESCRIPTION,
2011 kOsCrOS, 2023 kOsCrOS,
2012 SINGLE_VALUE_TYPE(extensions::switches::kEnableRemoteAssistance) 2024 SINGLE_VALUE_TYPE(extensions::switches::kEnableRemoteAssistance)
2013 }, 2025 },
2014 { 2026 {
2015 "disable-new-zip-unpacker", 2027 "disable-new-zip-unpacker",
2016 IDS_FLAGS_DISABLE_NEW_ZIP_UNPACKER_NAME, 2028 IDS_FLAGS_DISABLE_NEW_ZIP_UNPACKER_NAME,
2017 IDS_FLAGS_DISABLE_NEW_ZIP_UNPACKER_DESCRIPTION, 2029 IDS_FLAGS_DISABLE_NEW_ZIP_UNPACKER_DESCRIPTION,
2018 kOsCrOS, 2030 kOsCrOS,
2019 SINGLE_VALUE_TYPE(chromeos::switches::kDisableNewZIPUnpacker) 2031 SINGLE_VALUE_TYPE(chromeos::switches::kDisableNewZIPUnpacker)
2020 } 2032 },
2021 #endif // defined(OS_CHROMEOS) 2033 #endif // defined(OS_CHROMEOS)
2034 {
2035 "ssl-version-min",
2036 IDS_FLAGS_SSL_VERSION_MIN_NAME,
2037 IDS_FLAGS_SSL_VERSION_MIN_DESCRIPTION,
2038 kOsAll,
2039 MULTI_VALUE_TYPE(kSSLVersionMinChoices)
2040 },
2022 // NOTE: Adding new command-line switches requires adding corresponding 2041 // NOTE: Adding new command-line switches requires adding corresponding
2023 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2042 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2024 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2043 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2025 }; 2044 };
2026 2045
2027 const Experiment* experiments = kExperiments; 2046 const Experiment* experiments = kExperiments;
2028 size_t num_experiments = arraysize(kExperiments); 2047 size_t num_experiments = arraysize(kExperiments);
2029 2048
2030 // Stores and encapsulates the little state that about:flags has. 2049 // Stores and encapsulates the little state that about:flags has.
2031 class FlagsState { 2050 class FlagsState {
(...skipping 565 matching lines...) Expand 10 before | Expand all | Expand 10 after
2597 } 2616 }
2598 2617
2599 const Experiment* GetExperiments(size_t* count) { 2618 const Experiment* GetExperiments(size_t* count) {
2600 *count = num_experiments; 2619 *count = num_experiments;
2601 return experiments; 2620 return experiments;
2602 } 2621 }
2603 2622
2604 } // namespace testing 2623 } // namespace testing
2605 2624
2606 } // namespace about_flags 2625 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/net/ssl_config_service_manager_pref.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698