Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: gin/function_template.h

Issue 693943003: Update from https://crrev.com/302630 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/test_gpu_memory_buffer_manager.cc ('k') | gpu/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/function_template.h
diff --git a/gin/function_template.h b/gin/function_template.h
index 955ff53c284d416b8ffa33e2011635a342476c2c..2b66b666ac8b76ed1dfa36686bab2d9eeac6650a 100644
--- a/gin/function_template.h
+++ b/gin/function_template.h
@@ -150,8 +150,13 @@ class Invoker<IndicesHolder<indices...>, ArgTypes...>
// so it is guaranteed ArgumentHolders will be initialized (and thus, will
// extract arguments from Arguments) in the right order.
Invoker(Arguments* args, int create_flags)
- : ArgumentHolder<indices, ArgTypes>(args, create_flags)...,
- args_(args) {}
+ : ArgumentHolder<indices, ArgTypes>(args, create_flags)..., args_(args) {
+ // GCC thinks that create_flags is going unused, even though the
+ // expansion above clearly makes use of it. Per jyasskin@, casting
+ // to void is the commonly accepted way to convince the compiler
+ // that you're actually using a parameter/varible.
+ (void)create_flags;
+ }
bool IsOK() {
return And(ArgumentHolder<indices, ArgTypes>::ok...);
« no previous file with comments | « cc/test/test_gpu_memory_buffer_manager.cc ('k') | gpu/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698