Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: build/common.gypi

Issue 693943003: Update from https://crrev.com/302630 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/test_runner.py ('k') | build/config/BUILDCONFIG.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 6301aebbfe145bd3c163fdc6a40f17b619faaf17..4dbaa417387c75d5d1cd4e00d70071e248362ff2 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -61,6 +61,9 @@
# Whether we are using Views Toolkit
'toolkit_views%': 0,
+ # Use the PCI lib to collect GPU information.
+ 'use_libpci%': 1,
+
# Use OpenSSL instead of NSS as the underlying SSL and crypto
# implementation. Certificate verification will in most cases be
# handled by the OS. If OpenSSL's struct X509 is used to represent
@@ -136,6 +139,7 @@
'use_cras%': '<(use_cras)',
'use_ozone%': '<(use_ozone)',
'embedded%': '<(embedded)',
+ 'use_libpci%': '<(use_libpci)',
'use_openssl%': '<(use_openssl)',
'use_openssl_certs%': '<(use_openssl_certs)',
'enable_viewport%': '<(enable_viewport)',
@@ -281,6 +285,7 @@
'use_aura%': '<(use_aura)',
'use_ash%': '<(use_ash)',
'use_cras%': '<(use_cras)',
+ 'use_libpci%': '<(use_libpci)',
'use_ozone%': '<(use_ozone)',
'use_ozone_evdev%': '<(use_ozone_evdev)',
'use_clipboard_aurax11%': '<(use_clipboard_aurax11)',
@@ -308,11 +313,10 @@
# on compile-only bots).
'fastbuild%': 0,
- # Set to 1 to not store any build metadata (this isn't working yet but
- # this flag will help us to get there). See http://crbug.com/314403.
- # TODO(sebmarchand): Update this comment once this flag guarantee that
- # there's no build metadata in the build artifacts.
- 'dont_embed_build_metadata%': 0,
+ # Set to 1 to not store any build metadata, e.g. ifdef out all __DATE__
+ # and __TIME__. Set to 0 to reenable the use of these macros in the code
+ # base. See http://crbug.com/314403.
+ 'dont_embed_build_metadata%': 1,
# Set to 1 to force Visual C++ to use legacy debug information format /Z7.
# This is useful for parallel compilation tools which can't support /Zi.
@@ -768,9 +772,6 @@
'native_memory_pressure_signals%': 1,
'enable_printing%': 2,
'enable_task_manager%':0,
- # Set to 1 once we have a notification system for Android.
- # http://crbug.com/115320
- 'notifications%': 0,
'video_hole%': 1,
}],
@@ -1085,6 +1086,7 @@
'use_aura%': '<(use_aura)',
'use_ash%': '<(use_ash)',
'use_cras%': '<(use_cras)',
+ 'use_libpci%': '<(use_libpci)',
'use_openssl%': '<(use_openssl)',
'use_openssl_certs%': '<(use_openssl_certs)',
'use_nss%': '<(use_nss)',
@@ -1502,6 +1504,14 @@
'ozone_platform_test%': 0,
'conditions': [
+ ['buildtype=="Official"', {
+ # Continue to embed build meta data in Official builds, basically the
+ # time it was built.
+ # TODO(maruel): This decision should be revisited because having an
+ # official deterministic build has high value too but MSVC toolset can't
+ # generate anything deterministic with WPO enabled AFAIK.
+ 'dont_embed_build_metadata%': 0,
+ }],
# Enable the Syzygy optimization step for the official builds.
['OS=="win" and buildtype=="Official" and syzyasan!=1', {
'syzygy_optimize%': 1,
@@ -2975,6 +2985,9 @@
}],
], # conditions for 'target_defaults'
'target_conditions': [
+ ['<(use_libpci)==1', {
+ 'defines': ['USE_LIBPCI=1'],
+ }],
['<(use_openssl)==1', {
'defines': ['USE_OPENSSL=1'],
}],
@@ -4078,8 +4091,10 @@
'-Wno-reserved-user-defined-literal',
],
'cflags_cc': [
- # See the comment in the Mac section for what it takes to move
- # this to -std=c++11.
+ # gnu++11 instead of c++11 is needed because some code uses
+ # typeof() (a GNU extension).
+ # TODO(thakis): Eventually switch this to c++11 instead,
+ # http://crbug.com/427584
'-std=gnu++11',
],
}],
@@ -4834,12 +4849,7 @@
# Note that the prebuilt Clang binaries should not be used for iOS
# development except for ASan builds.
['clang==1', {
- # gnu++11 instead of c++11 is needed because some code uses
- # typeof() (a GNU extension).
- # TODO(thakis): Eventually switch this to c++11 instead of
- # gnu++11 (once typeof can be removed, which is blocked on c++11
- # being available everywhere).
- 'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++11', # -std=gnu++11
+ 'CLANG_CXX_LANGUAGE_STANDARD': 'c++11', # -std=c++11
# Warn if automatic synthesis is triggered with
# the -Wobjc-missing-property-synthesis flag.
'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'YES',
@@ -5572,6 +5582,7 @@
'-Wno-unused-value',
'-Wno-unused-variable',
'-Wno-unused-local-typedef', # http://crbug.com/411648
+ '-Wno-inconsistent-missing-override', #http://crbug.com/428099
],
},
}],
« no previous file with comments | « build/android/test_runner.py ('k') | build/config/BUILDCONFIG.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698